Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0075-clear-window] 初回読込時のclearWindowをカット 他 #464

Merged
merged 2 commits into from Oct 2, 2019
Merged

[0075-clear-window] 初回読込時のclearWindowをカット 他 #464

merged 2 commits into from Oct 2, 2019

Conversation

cwtickle
Copy link
Owner

@cwtickle cwtickle commented Oct 2, 2019

変更内容

  1. 初回読込時のclearWindowをカット
  2. ローカルmp3の読込失敗時のメッセージ追加

変更理由

  1. 初回読込時に一瞬消えたような挙動になるのと、
    そのタイミングでdivRoot以外のオブジェクトが参照されたときにエラーとなるため。
  2. ローカルmp3の読込失敗時のメッセージを確認する方法が無かったため。

その他コメント

@cwtickle cwtickle merged commit 12f8372 into develop Oct 2, 2019
@cwtickle cwtickle mentioned this pull request Oct 2, 2019
Merged
@cwtickle cwtickle deleted the hotfix/0075-clear-window branch October 6, 2019 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
func:Loading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cwtickle