Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

titlegrdが1行分だけ指定されているとき2行目が表示されない問題の修正 #618

Merged
merged 1 commit into from Feb 28, 2020
Merged

titlegrdが1行分だけ指定されているとき2行目が表示されない問題の修正 #618

merged 1 commit into from Feb 28, 2020

Conversation

suzme
Copy link
Contributor

@suzme suzme commented Feb 27, 2020

変更内容

titlegrdの2行目分($区切り以降)省略時、1行目分の値を使うようにしました。

変更理由

以下のように指定するとタイトル1行目(foo)のみが表示され、2行目(bar)が表示されません。

|titlegrd=#ff0000|
|musicTitle=foo<br>bar|

その他コメント

MFV2さんのツイートより

@codeclimate
Copy link

codeclimate bot commented Feb 27, 2020

Code Climate has analyzed commit 4af1e35 and detected 0 issues on this pull request.

View more on Code Climate.

@cwtickle cwtickle added bug Something isn't working func:Title labels Feb 28, 2020
cwtickle
cwtickle approved these changes Feb 28, 2020
View reviewed changes
Copy link
Owner

@cwtickle cwtickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request ありがとうございます！
問題ないと思いますので、マージします。

@cwtickle cwtickle merged commit 3aa8602 into cwtickle:develop Feb 28, 2020
@cwtickle cwtickle mentioned this pull request Feb 28, 2020
Merged
@suzme suzme deleted the fix-titlefontgrd2 branch August 14, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwtickle cwtickle cwtickle approved these changes

Assignees
No one assigned
Labels
bug Something isn't working func:Title
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suzme @cwtickle