Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0185/display-replace] Display:filterLine実装、Displayオプションの配置変更 #655

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

cwtickle
Copy link
Owner

変更内容

  1. Displayオプションに「filterLine」を追加しました。
    「Hidden+」「Sudden+」「Hid&Sud+」設定時に表示するフィルターの境界線が消せるようになります。
  2. 「pageUp」「pageDown」の説明文を簡略化しました。

変更理由

  1. フィルターの境界線が無くても、パーセント表記があれば判別がつく場合があるため。
  2. 横幅が500pxのとき、説明文が2段になってしまうため。

その他コメント

@codeclimate
Copy link

codeclimate bot commented Apr 16, 2020

Code Climate has analyzed commit 1401054 and detected 0 issues on this pull request.

View more on Code Climate.

@cwtickle cwtickle merged commit a252460 into develop Apr 16, 2020
@cwtickle cwtickle changed the title [0183/display-replace] Display:filterLine実装、Displayオプションの配置変更 [0185/display-replace] Display:filterLine実装、Displayオプションの配置変更 Apr 17, 2020
@cwtickle cwtickle deleted the hotfix/0185-display-replace branch April 17, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant