Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0230/extra-key-after] 特殊キーの後に通常キーの譜面があると譜面選択できない問題を修正 #729

Merged
merged 1 commit into from
May 24, 2020

Conversation

cwtickle
Copy link
Owner

@cwtickle cwtickle commented May 24, 2020

変更内容

  1. 特殊キーの後に通常キーの譜面があると譜面選択できない問題を修正しました。

変更理由

  1. g_localKeyStorageが未定義のタイミングでg_localKeyStorage.reverseに値を格納しているため。
    1譜面目の場合、setDifficultyの_initFlgがfalseであり、
    通常/特殊キーによらずこの格納処理が素通りされるため問題は発生しない。

その他コメント

  • 過去バージョンでも再現あり。修正が必要です。

@cwtickle cwtickle added bug Something isn't working func:Settings labels May 24, 2020
@codeclimate
Copy link

codeclimate bot commented May 24, 2020

Code Climate has analyzed commit 7590506 and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working func:Settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant