Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0323/code-refactoring] コード整理 #926

Merged
merged 7 commits into from Jan 4, 2021

Conversation

cwtickle
Copy link
Owner

🔨 変更内容 / Details of Changes

  • Code Climateで指摘のあったコードに対して一部修正を実施しました。

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

  • 上述の通り。

📷 スクリーンショット / Screenshot

📝 その他コメント / Other Comments

  • 重複コードは避けますが、なるべく設定系はdanoni_constants.jsへ持っていくようにする予定です。

@codeclimate
Copy link

codeclimate bot commented Jan 4, 2021

Code Climate has analyzed commit 4a02e9e and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@cwtickle cwtickle marked this pull request as ready for review January 4, 2021 12:38
@cwtickle cwtickle merged commit 378212b into develop Jan 4, 2021
@cwtickle cwtickle deleted the feature/0323-code-refactoring branch January 16, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant