Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0327/deprecated-func] 非推奨関数をlegacy_functionへ移動 #934

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

cwtickle
Copy link
Owner

@cwtickle cwtickle commented Jan 6, 2021

🔨 変更内容 / Details of Changes

  • 非推奨関数(createDivCssLabel, createCssButton, createColorObject)を
    danoni_legacy_function.jsへ移動しました。

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

  • v17以降は別関数にて定義しているため。
  • 後継関数への移行を進めるため。

📷 スクリーンショット / Screenshot

📝 その他コメント / Other Comments

  • danoni_legacy_function.jsへ移動しただけなので、
    danoni_legacy_function.jsを入れておけばこれまでと変わりません。
  • 今後、カスタムで利用する場合は
    createDivCss2Label, createCss2Button, createColorObject2 の利用を推奨します。

@codeclimate
Copy link

codeclimate bot commented Jan 6, 2021

Code Climate has analyzed commit dca70a2 and detected 0 issues on this pull request.

View more on Code Climate.

@cwtickle cwtickle merged commit 04cf4a7 into develop Jan 6, 2021
@cwtickle cwtickle deleted the feature/0327-deprecated-func branch January 17, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant