Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0330/reset-window] 画面初期表示と画面消去を統一 #938

Merged
merged 3 commits into from
Jan 16, 2021

Conversation

cwtickle
Copy link
Owner

🔨 変更内容 / Details of Changes

  • 画面初期表示と画面消去を統一しました。
    titleInit / optionInit / settingsDisplayInit / loadMusic / MainInit / resultInit の処理の先頭に
    clearWindow() 処理を追加しています。

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

  • 処理の単純化のため。

📷 スクリーンショット / Screenshot

📝 その他コメント / Other Comments

  • ボタン処理をコピーしてカスタムしている場合、clearWindowが二重に動く可能性があります。
    (二重に動かしても問題はありません)

clearWindow();
settingsDisplayInit();
}, {
createCss2Button(`btnDisplay`, `>`, _ => settingsDisplayInit(), {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

clearWindow();
optionInit();
}, {
createCss2Button(`btnSettings`, `<`, _ => optionInit(), {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Jan 16, 2021

Code Climate has analyzed commit 40d6ac4 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

View more on Code Climate.

@cwtickle cwtickle merged commit d415f5d into develop Jan 16, 2021
@cwtickle cwtickle deleted the feature/0330-reset-window branch January 19, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant