-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cocoapods installation #118
Conversation
@@ -44,6 +44,9 @@ package.dependencies += [ | |||
|
|||
```ruby | |||
pod 'CombineX', "~> 0.3.1" | |||
|
|||
# or, if you want to use `Foundation` extensions: | |||
pod 'CombineX/CXFoundation', "~> 0.3.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have very little knowledge of CocoaPods. So we don't need to state CXFoundation explicitly before, but now we do? With duplicate version number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an either-or
pod 'CombineX'
means you only want CombineX
.
pod 'CombineX/CXFoundation
means you want CombineX
, and CXFoundation
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did users need pod 'CombineX/CXFoundation'
before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if they want to use CXFoundation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
and we may have encountered a compiler bug