Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cocoapods installation #118

Merged
merged 2 commits into from
May 31, 2021
Merged

Fix cocoapods installation #118

merged 2 commits into from
May 31, 2021

Conversation

luoxiu
Copy link
Member

@luoxiu luoxiu commented May 31, 2021

and we may have encountered a compiler bug

@luoxiu luoxiu requested a review from ddddxxx May 31, 2021 07:36
@@ -44,6 +44,9 @@ package.dependencies += [

```ruby
pod 'CombineX', "~> 0.3.1"

# or, if you want to use `Foundation` extensions:
pod 'CombineX/CXFoundation', "~> 0.3.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have very little knowledge of CocoaPods. So we don't need to state CXFoundation explicitly before, but now we do? With duplicate version number?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an either-or

pod 'CombineX' means you only want CombineX.
pod 'CombineX/CXFoundation means you want CombineX, and CXFoundation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did users need pod 'CombineX/CXFoundation' before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if they want to use CXFoundation

Copy link
Member

@ddddxxx ddddxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luoxiu luoxiu merged commit a818ef0 into master May 31, 2021
@luoxiu luoxiu deleted the fix-cocoapods-installation branch May 31, 2021 08:45
luoxiu added a commit that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants