Fix threading issue for sending values on subjects #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @FranzBusch , I've created a pr to your branch and I think it will fix this, take a look when you have time! |
|
@luoxiu The CI failed, these are the same failures that I saw locally when trying to fix it. It is either that the new test is green and the synchronous backpressure one is red or the other way round. |
|
Ci succeeded on mac but failed on linux…… Hey, @FranzBusch , can you fix the conflicting issue? I've updated the travis's conf, let's start a new round of testing to see what will happen. |
|
Sure will do! |
FranzBusch
force-pushed
the
bugfix/subject-receive-value-synchronization
branch
from
1ea7a6a
to
9a95018
Compare
ddddxxx
requested changes
Oct 22, 2019
| @@ -2,6 +2,14 @@ public final class Atom<Val> { | |||
|
|
|||
| private let lock = Lock() | |||
| private var val: Val | |||
|
|
|||
| var isMutating: Bool { | |||
| if lock.try() { | |||
There was a problem hiding this comment.
@FranzBusch Your changes to the Lock was lost, :-D
|
@luoxiu We could probably add a new test target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the two subjects
CurrentValueSubjectandPassthroughSubjectthat the sending of new values is not synchronised. Right now this is only adding the tests to verify but I am working on implementing a fix as well, if you have input how it should be fixed please let me know.