Update PlayCanvas env lighting #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slimbuck Thank you for your wonderful PR. This is a Christmas present for me. |
|
This is such an amazing tool and resource @cx20. Thanks so much all the hard work you've put into it!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gltf-test currently appears to load low dynamic range environment. This looks significantly different compared to the other engines.
This PR uses the prefiltering introduced in 1.51 to load a single equirect HDR environment map and generate skybox, reflection and ambient data at load time.
The difference is significant:
Before:
After:
The PR also uses linear tonemapping instead of ACES, which more closely matches the other engines.
Please note: some of the API used here is new and still flagged as internal. The API should be released soon though, perhaps with changes, in the next one or two engine releases.