Added an option to specify optional XOR key to use with each hash value #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue (common technique used by malware authors). Similar functionality already exists in hashdb-ida.
|
Hello @cr7pt0pl4gu3! Thank you very much for your contribution. I apologize for missing this PR for so long. I will review this as soon as I can. |
cxiao
reviewed
Jan 8, 2024
There was a problem hiding this comment.
Hey @cr7pt0pl4gu3, I've just finished the review here - I've made a few comments and proposed changes. I think once those are done this is good to merge; after this is merged, I'll make a new release and get the version in the Binja plugin repo updated. Let me know if you have any questions about my comments.
cxiao
reviewed
Jan 8, 2024
cxiao
reviewed
Jan 8, 2024
Co-authored-by: Cindy Xiao <1661230+cxiao@users.noreply.github.com>
Co-authored-by: Cindy Xiao <1661230+cxiao@users.noreply.github.com>
Co-authored-by: Cindy Xiao <1661230+cxiao@users.noreply.github.com>
Co-authored-by: Cindy Xiao <1661230+cxiao@users.noreply.github.com>
Co-authored-by: Cindy Xiao <1661230+cxiao@users.noreply.github.com>
Co-authored-by: Cindy Xiao <1661230+cxiao@users.noreply.github.com>
|
Yep, agree to everything, thank you for your suggestions and fixes :D |
|
@cxiao @cr7pt0pl4gu3 - Apologies I created issue #18 for this as I did not see this pull request. What is still outstanding in order to have this merged? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to specify optional XOR key to use with each hash value (common technique used by malware authors). Similar option already exists in hashdb-ida.
I find it useful sometimes and decided to implement the functionality for it. Please let me know if everything is acceptable and can be merged.