-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an option to specify optional XOR key to use with each hash value #16
base: master
Are you sure you want to change the base?
Conversation
…ue (common technique used by malware authors). Similar functionality already exists in hashdb-ida.
Hello @cr7pt0pl4gu3! Thank you very much for your contribution. I apologize for missing this PR for so long. I will review this as soon as I can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cr7pt0pl4gu3, I've just finished the review here - I've made a few comments and proposed changes. I think once those are done this is good to merge; after this is merged, I'll make a new release and get the version in the Binja plugin repo updated. Let me know if you have any questions about my comments.
Co-authored-by: Cindy Xiao <1661230+cxiao@users.noreply.github.com>
Co-authored-by: Cindy Xiao <1661230+cxiao@users.noreply.github.com>
Co-authored-by: Cindy Xiao <1661230+cxiao@users.noreply.github.com>
Co-authored-by: Cindy Xiao <1661230+cxiao@users.noreply.github.com>
Co-authored-by: Cindy Xiao <1661230+cxiao@users.noreply.github.com>
Co-authored-by: Cindy Xiao <1661230+cxiao@users.noreply.github.com>
Yep, agree to everything, thank you for your suggestions and fixes :D |
@cxiao @cr7pt0pl4gu3 - Apologies I created issue #18 for this as I did not see this pull request. What is still outstanding in order to have this merged? Thanks |
Added an option to specify optional XOR key to use with each hash value (common technique used by malware authors). Similar option already exists in hashdb-ida.
I find it useful sometimes and decided to implement the functionality for it. Please let me know if everything is acceptable and can be merged.