Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixing int32 and int64 types in comparisons leads to errors (certainl… #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Mixing int32 and int64 types in comparisons leads to errors (certainl… #1

wants to merge 4 commits into from

Commits on Jul 5, 2020

  1. Mixing int32 and int64 types in comparisons leads to errors (certainl… 

    …y on x86_64 builds)
    @FreeBear-nc
    FreeBear-nc committed Jul 5, 2020
    Configuration menu
    Copy the full SHA
    6552aa9 View commit details
    Browse the repository at this point in the history

  2. Added basic fixedpt_sqrt test for 64bit

    @FreeBear-nc
    FreeBear-nc committed Jul 5, 2020
    Configuration menu
    Copy the full SHA
    de819ea View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Add test to fixedpt_div to avoid a divide by zero.

    @FreeBear-nc
    FreeBear-nc committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    2e2a55c View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2020

  1. If using (for example) a 10.22 format, fixedpt_sqrt falls apart with … 

    …values

of 8, 64, ...
The issue is down in part, to the return value of fixedpt_div being truncated
in the conversion from fixedptd to fixedpt
    @FreeBear-nc
    FreeBear-nc committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    ce5a6a1 View commit details
    Browse the repository at this point in the history