-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax error in onTabReplaced() #304
Comments
Thanks for reporting! Would you please try branch |
I'm now running 0.3.1.1 in parallel. I'll know if it works properly in a few hours. Edit: One of the computers I'm using has only 2G of ram. It's not a problem with the old win7. And with ublock running in my browsers the webpages are much lighter. So the browser is still perfectly functionnal. It starts swapping when I reach 15-20 tabs (or less if they are big pages). |
The fix works. I don't have orphaned tabs left in TF list. in 0.3.0
in 0.3.1.1:
|
Sorry --- missed that second item (now marked "Item 2") when I read your initial report! Fixed in force-pushed |
I can confirm. Comparing side by side: |
@Procyon-b Much appreciated! Will release shortly. |
0.3.1 submitted for Google review --- will tag when it is released. |
It's released. :) |
Item 1
In the final code, line 37839 of
main.js
, in the functiononTabReplaced()
addedTabID
is undefined. It should beaddedTabId
Item 2
I'm running 2 instances of TF and the fixed version works correctly, but then I also see an error once on line 37847 where it tells me that
tab_val
is undefined. I've fixed it temporarily with a try-catch.The text was updated successfully, but these errors were encountered: