Fix command injection vulnerability #23
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix passing of unescaped text to the arguments of notification command in dcnnt/plugins/notifications.py This is a high-risk vulnerability that can lead to RCE and allow arbitrary code execution on the server while the notification showing. All text received over the network MUST be escaped before being transmitted to the database or to the shell command arguments.
|
Merged. Thanks for important fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix passing of unescaped text to the arguments of notification command in dcnnt/plugins/notifications.py
This is a high-risk vulnerability that can lead to RCE and allow arbitrary code execution on the server while the notification showing.
All text received over the network MUST be escaped before being transmitted to the database or to the shell command arguments.
(Old PR was closed due to accidental deletion of the repository)