-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♥ Fixed the heart emoji in cutefetch #8
Conversation
BTW while editing the README.md I noticed the # Extra instruction to randomize the animals face and I find it funny because I did something kinda similar but with a predefined set of faces (because some of them are too big to fit on this cat) This is my fetch function: # welcome screen
fetch () {
eyes=(0 1 2 3 4 6 7 8 11 12 14)
cutefetch -k2 $(shuf -e "${eyes[@]}" -n 1)
}
fetch |
Huh, wow. Didn't realize the shuf command could be shortened like that just by using an array. Thanks for the info and suggestions. I'll play around with it a bit and see if I want to implement something like that internally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Merging.
yay that'd be wonderful!
|
Thank you for making this awesome project. Btw you should submit a pull request to add it to https://github.com/fosslife/awesome-ricing#fetches and the other fetch oriented awesome list. |
Thanks a lot for the suggestion. I'll definitely make a PR to add it there. Didn't even know it existed 😅 |
@Kalitsune Made a new issue (#9) for the randomizer. Let me know if you'd like to implement it, since you already have most of the code ready. No worries if you're too busy; I can do it later too if need be. |
Hi, I will try to implement it if I have the time! |
Sure. Feel free to whenever. It's just a fetch script that very few people use anyway, so nothing urgent. Thanks a lot. |
The heart in the window manager section presented a display issue. This Pull Request changes the glyph for the window manager to a heart glyph from the widely used NerdFont.
This pull request is a follow up from the discussion in #7.