Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♥ Fixed the heart emoji in cutefetch #8

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

Kalitsune
Copy link
Contributor

image
The heart in the window manager section presented a display issue. This Pull Request changes the glyph for the window manager to a heart glyph from the widely used NerdFont.

This pull request is a follow up from the discussion in #7.

@cybardev cybardev added the bug Something isn't working label Nov 15, 2023
@Kalitsune
Copy link
Contributor Author

Kalitsune commented Nov 15, 2023

BTW while editing the README.md I noticed the # Extra instruction to randomize the animals face and I find it funny because I did something kinda similar but with a predefined set of faces (because some of them are too big to fit on this cat)

This is my fetch function:

# welcome screen
fetch () {
  eyes=(0 1 2 3 4 6 7 8 11 12 14)
  cutefetch -k2 $(shuf -e "${eyes[@]}" -n 1)
}
fetch

@cybardev
Copy link
Owner

Huh, wow. Didn't realize the shuf command could be shortened like that just by using an array. Thanks for the info and suggestions.

I'll play around with it a bit and see if I want to implement something like that internally.
Will keep as is for now, but I'll let you know.

@cybardev
Copy link
Owner

cybardev commented Nov 15, 2023

An interesting thing I notice with the dev branch is that the heart changed on my Mac.

image

So, previously on Mac I had outline heart, and on Linux it was broken. Now, on Linux I have an outline heart and on Mac it's filled.

I do use NerdFonts everywhere (and have been for years), so not sure what's happening. Maybe my Mac has outdated NerdFonts or something. Will have to look into it.

Regardless, I like how it looks on both platforms, so I'll merge it now.
Thanks again for your wonderful contributions. 😊

@cybardev cybardev self-requested a review November 15, 2023 19:02
Copy link
Owner

@cybardev cybardev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Merging.

@cybardev cybardev merged commit 95050d3 into cybardev:main Nov 15, 2023
@Kalitsune
Copy link
Contributor Author

yay that'd be wonderful!

Huh, wow. Didn't realize the shuf command could be shortened like that just by using an array. Thanks for the info and suggestions.

I'll play around with it a bit and see if I want to implement something like that internally. Will keep as is for now, but I'll let you know.

@Kalitsune
Copy link
Contributor Author

Kalitsune commented Nov 15, 2023

Thank you for making this awesome project. Btw you should submit a pull request to add it to https://github.com/fosslife/awesome-ricing#fetches and the other fetch oriented awesome list.
Because this project is exactly what I was looking for but it was hard to find.. ^^'

@cybardev
Copy link
Owner

Thanks a lot for the suggestion. I'll definitely make a PR to add it there. Didn't even know it existed 😅

@cybardev
Copy link
Owner

@Kalitsune Made a new issue (#9) for the randomizer. Let me know if you'd like to implement it, since you already have most of the code ready. No worries if you're too busy; I can do it later too if need be.

@Kalitsune
Copy link
Contributor Author

Hi, I will try to implement it if I have the time!
Not really sure if I'll have the time today tho

@cybardev
Copy link
Owner

Hi, I will try to implement it if I have the time!
Not really sure if I'll have the time today tho

Sure. Feel free to whenever. It's just a fetch script that very few people use anyway, so nothing urgent. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants