Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log system is missing #59

Closed
guyluz11 opened this issue Sep 13, 2021 · 2 comments · Fixed by #60
Closed

Log system is missing #59

guyluz11 opened this issue Sep 13, 2021 · 2 comments · Fixed by #60
Assignees
@guyluz11
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@guyluz11
Copy link
Member

Currently we are using print to log our Info Warnings and Errors.

Let's find a better way to do so
@guyluz11 guyluz11 self-assigned this Sep 13, 2021
@guyluz11 guyluz11 added enhancement New feature or request good first issue Good for newcomers labels Sep 13, 2021
@guyluz11
Copy link
Member Author

Let's go with logger as it is popular and looks good.

@guyluz11 guyluz11 mentioned this issue Sep 13, 2021
Merged
@guyluz11 guyluz11 linked a pull request Sep 13, 2021 that will close this issue
Add files for xiaomi #57 and closed #59 #60
Merged
guyluz11 added a commit that referenced this issue Sep 13, 2021
@guyluz11
Merge pull request #60 from guyluz11/dev
32cabfe 
Add files for xiaomi #57 and closed #59
@guyluz11
Copy link
Member Author

Thanks

@guyluz11 guyluz11 mentioned this issue Sep 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyluz11 guyluz11

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add files for xiaomi #57 and closed #59 guyluz11/cbj_hub
1 participant
@guyluz11