Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all prints to logs #61

Closed
guyluz11 opened this issue Sep 13, 2021 · 3 comments · Fixed by #80 or #82
Closed

Convert all prints to logs #61

guyluz11 opened this issue Sep 13, 2021 · 3 comments · Fixed by #80 or #82
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers improving code organization All the staff that improve code without change to functionality super easy Super easy issue that can be solved even by programmers that not familiar withe the programming lang

Comments

@guyluz11
Copy link
Member

Follow up to #59 we now need to convert all the pints in the app to use the new log system that we have added.

Just use logger.i('Text'); instead of print('Text'); and import the logger function from
import package:cbj_hub/utils.dart';

Here are the types of log that you can use

logger.v("Verbose log");

logger.d("Debug log");

logger.i("Info log");

logger.w("Warning log");

logger.e("Error log");

logger.wtf("What a terrible failure log");
@guyluz11 guyluz11 added enhancement New feature or request good first issue Good for newcomers improving code organization All the staff that improve code without change to functionality super easy Super easy issue that can be solved even by programmers that not familiar withe the programming lang labels Sep 13, 2021
@guyluz11 guyluz11 linked a pull request Oct 8, 2021 that will close this issue
@guyluz11
Copy link
Member Author

guyluz11 commented Oct 8, 2021

Thanks @BangBuster is that all the prints or there are more left?

@EilayDev
Copy link
Contributor

EilayDev commented Oct 9, 2021

@guyluz11 the last PR was only for the error prints, if you find any I missed, let me know!

@guyluz11 guyluz11 linked a pull request Oct 10, 2021 that will close this issue
@guyluz11
Copy link
Member Author

Done

Thanks @BangBuster will close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers improving code organization All the staff that improve code without change to functionality super easy Super easy issue that can be solved even by programmers that not familiar withe the programming lang
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants