Skip to content

Commit

Permalink
[ci skip] comment out deployment as ragger is now retired
Browse files Browse the repository at this point in the history
  • Loading branch information
JonJagger committed Jan 17, 2020
1 parent b6bddc5 commit 748a7a7
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 10 deletions.
3 changes: 3 additions & 0 deletions .circleci/deploy_to_namespace.sh
@@ -1,5 +1,8 @@
#!/bin/bash -Eeu

echo The ragger service is now part of the runner service
exit 0

readonly NAMESPACE="${1}" # eg beta

# misc env-vars are in ci context
Expand Down
2 changes: 2 additions & 0 deletions docker-compose.yml
Expand Up @@ -28,6 +28,7 @@ services:
init: true
container_name: test-ragger-server
environment: [ NO_PROMETHEUS ]
export: ${CYBER_DOJO_RAGGER_PORT}
ports: [ "${CYBER_DOJO_RAGGER_PORT}:${CYBER_DOJO_RAGGER_PORT}" ]
read_only: true
tmpfs: /tmp
Expand All @@ -42,6 +43,7 @@ services:
image: ${CYBER_DOJO_RUNNER_IMAGE}:${CYBER_DOJO_RUNNER_TAG}
init: true
environment: [ NO_PROMETHEUS ]
export: ${CYBER_DOJO_RUNNER_PORT}
read_only: true
tmpfs: /tmp
restart: 'no'
Expand Down
6 changes: 3 additions & 3 deletions docs/image-names.txt
Expand Up @@ -22,9 +22,9 @@ in the list served to the puller. Doing this makes it much more
attractive to time-limit a kata so old image-names can be
properly retired.

Adding the commit SHA inside the image as an env-var means
when you restart a session you can be notified if the target
image has changed. Assuming the manifest holds the original sha.
>>Adding the commit SHA inside the image as an env-var means
>>when you restart a session you can be notified if the target
>>image has changed. Assuming the manifest holds the original sha.

With separate repos, the Dockerfile needs its commands to be
more carefully written to install specific versions.
2 changes: 1 addition & 1 deletion docs/new-linter-service.txt
Expand Up @@ -36,6 +36,6 @@ Possible names like linter...
evaluator
grader
assessor
appraiser,
appraiser
feedbacker
signaller
13 changes: 7 additions & 6 deletions docs/notes.txt
Expand Up @@ -6,13 +6,14 @@ if it detects the run is on CI. Otherwise it assumes
to use ${ROOT_DIR}/../commander/cyber-dojo
A better approach (which should be used in all the repos) is...

if ${ROOT_DIR}/../commander/cyber-dojo exists
use it
else if /tmp/cyber-dojo exists
use it
if [ -f "${ROOT_DIR}/../commander/cyber-dojo" ]; then
echo "${ROOT_DIR}/../commander/cyber-dojo"
elif [ -f "/tmp/cyber-dojo" ]; then
echo "/tmp/cyber-dojo"
else
curl cyber-dojo into /tmp/cyber-dojo
use it
url=....
curl --fail --output /tmp/cyber-dojo --silent "${url}"
echo "/tmp/cyber-dojo"
fi

So in time, ragger will only be used if the rag-lambda is exposed.
Expand Down

0 comments on commit 748a7a7

Please sign in to comment.