Switch to new saver group/kata create() methods

cyber-dojo · Aug 15, 2021 · 3225f1b · 3225f1b
1 parent 135589f
commit 3225f1b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 21 deletions.
diff --git a/source/server/code/creator.rb b/source/server/code/creator.rb
@@ -16,7 +16,7 @@ def group_create_custom(display_name:)
   end
 
   def group_create(language_name:, exercise_name:)
-    id = saver.group_create2(language_name, exercise_name)
+    id = saver.group_create(language_name, exercise_name)
     manifest = saver.group_manifest(id)
     pull_image_onto_nodes(id, manifest['image_name'])
     id
@@ -32,7 +32,7 @@ def kata_create_custom(display_name:)
   end
 
   def kata_create(language_name:, exercise_name:)
-    id = saver.kata_create2(language_name, exercise_name)
+    id = saver.kata_create(language_name, exercise_name)
     manifest = saver.kata_manifest(id)
     pull_image_onto_nodes(id, manifest['image_name'])
     id

diff --git a/source/server/code/external_saver.rb b/source/server/code/external_saver.rb
@@ -21,7 +21,7 @@ def group_create_custom(display_name)
     })
   end
 
-  def group_create2(ltf_name, exercise_name)
+  def group_create(ltf_name, exercise_name)
     @http.post(__method__, {
       version: CURRENT_VERSION,
       ltf_name: ltf_name,
@@ -33,13 +33,6 @@ def group_exists?(id)
     @http.get(__method__, { id:id })
   end
 
-  def group_create(manifests, options)
-    @http.post(__method__, {
-      manifests: manifests,
-      options: options
-    })
-  end
-
   def group_manifest(id)
     @http.get(__method__, { id:id })
   end
@@ -61,7 +54,7 @@ def kata_create_custom(display_name)
     })
   end
 
-  def kata_create2(ltf_name, exercise_name)
+  def kata_create(ltf_name, exercise_name)
     @http.post(__method__, {
       version: CURRENT_VERSION,
       ltf_name: ltf_name,
@@ -73,13 +66,6 @@ def kata_exists?(id)
     @http.get(__method__, { id:id })
   end
 
-  def kata_create(manifest, options)
-    @http.post(__method__, {
-      manifest: manifest,
-      options: options
-    })
-  end
-
   def kata_manifest(id)
     @http.get(__method__, { id:id })
   end

diff --git a/test/server/metrics.rb b/test/server/metrics.rb
@@ -15,11 +15,11 @@
 
   app: {
     lines: {
-       total:423,
-      missed:8,
+       total:416,
+      missed:6,
     },
     branches: {
-       total:28,
+       total:26,
       missed:3,
     }
   },