Ci rename variable (#13)

* In CI workflows rename ARTIFACT_NAME to IMAGE_NAME * In CI workflows remove unneeded quotes
cyber-dojo · Dec 2, 2023 · d86de66 · d86de66
1 parent 2b8fa1d
commit d86de66
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 22 deletions.
diff --git a/.github/workflows/main_staging.yml b/.github/workflows/main_staging.yml
@@ -51,9 +51,9 @@ jobs:
       - name: Report image to Kosli flow
         run: |
           IMAGE_TAG="$(echo $GITHUB_SHA | head -c7)"
-          ARTIFACT_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${IMAGE_TAG}
-          docker pull ${ARTIFACT_NAME}     
-          kosli report artifact ${ARTIFACT_NAME} \
+          IMAGE_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${IMAGE_TAG}
+          docker pull ${IMAGE_NAME}     
+          kosli report artifact ${IMAGE_NAME} \
             --artifact-type=docker
 
   test:

diff --git a/.github/workflows/sub_approve_deployment.yml b/.github/workflows/sub_approve_deployment.yml
@@ -41,18 +41,18 @@ jobs:
 
       - name: Report approval of deployment
         run: |
-          ARTIFACT_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${{ inputs.IMAGE_TAG }}          
-          docker pull ${ARTIFACT_NAME}
-          kosli report approval ${ARTIFACT_NAME} \
+          IMAGE_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${{ inputs.IMAGE_TAG }}          
+          docker pull ${IMAGE_NAME}
+          kosli report approval ${IMAGE_NAME} \
             --artifact-type=docker \
             --environment=${{ inputs.KOSLI_ENVIRONMENT }} \
             --approver="${{ github.actor }}"
 
       - name: Report expected deployment to Kosli
         run: |
-          ARTIFACT_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${{ inputs.IMAGE_TAG }}          
-          docker pull ${ARTIFACT_NAME}
-          kosli expect deployment ${ARTIFACT_NAME} \
+          IMAGE_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${{ inputs.IMAGE_TAG }}          
+          docker pull ${IMAGE_NAME}
+          kosli expect deployment ${IMAGE_NAME} \
             --artifact-type=docker \
             --description="Deployed to ${{ inputs.KOSLI_ENVIRONMENT }} in Github Actions pipeline" \
             --environment=${{ inputs.KOSLI_ENVIRONMENT }}
diff --git a/.github/workflows/sub_build_image.yml b/.github/workflows/sub_build_image.yml
@@ -53,6 +53,6 @@ jobs:
 
       - name: Report image to Kosli flow
         run: |
-          ARTIFACT_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${{ inputs.IMAGE_TAG }}                    
-          kosli report artifact ${ARTIFACT_NAME} \
+          IMAGE_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${{ inputs.IMAGE_TAG }}                    
+          kosli report artifact ${IMAGE_NAME} \
             --artifact-type=docker
diff --git a/.github/workflows/sub_sdlc_gate.yml b/.github/workflows/sub_sdlc_gate.yml
@@ -32,7 +32,7 @@ jobs:
 
       - name: Kosli SDLC gate to short-circuit-the-flow
         run: |
-          ARTIFACT_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${{ inputs.IMAGE_TAG }}          
-          docker pull ${ARTIFACT_NAME}
-          kosli assert artifact ${ARTIFACT_NAME} \
+          IMAGE_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${{ inputs.IMAGE_TAG }}          
+          docker pull ${IMAGE_NAME}
+          kosli assert artifact ${IMAGE_NAME} \
             --artifact-type=docker          
diff --git a/.github/workflows/sub_test.yml b/.github/workflows/sub_test.yml
@@ -68,9 +68,9 @@ jobs:
 
       - name: Report Snyk results to Kosli flow
         run: |
-          ARTIFACT_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${{ inputs.IMAGE_TAG }}
-          docker pull ${ARTIFACT_NAME}
-          kosli report evidence artifact snyk ${ARTIFACT_NAME} \
+          IMAGE_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${{ inputs.IMAGE_TAG }}
+          docker pull ${IMAGE_NAME}
+          kosli report evidence artifact snyk ${IMAGE_NAME} \
             --artifact-type=docker  \
             --name=snyk-scan  \
             --scan-results=snyk.json
@@ -98,9 +98,9 @@ jobs:
           cp "$(repo_root)/.rubocop.yml" "${LINT_EVIDENCE_DIR}"/.rubocop.yml
           gem install rubocop
           if [ rubocop "$(repo_root)" | tee "${LINT_EVIDENCE_DIR}"/rubocop.log ]; then
-            export KOSLI_LINT_COMPLIANT='true'
+            export KOSLI_LINT_COMPLIANT=true
           else
-            export KOSLI_LINT_COMPLIANT='false'
+            export KOSLI_LINT_COMPLIANT=false
           fi
 
           kosli report evidence commit generic \
@@ -125,9 +125,9 @@ jobs:
 
       - name: Report pull-request evidence to Kosli
         run: |
-          ARTIFACT_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${{ inputs.IMAGE_TAG }}          
-          docker pull ${ARTIFACT_NAME}
-          kosli report evidence artifact pullrequest github ${ARTIFACT_NAME} \
+          IMAGE_NAME=cyberdojo/${{ env.KOSLI_FLOW }}:${{ inputs.IMAGE_TAG }}          
+          docker pull ${IMAGE_NAME}
+          kosli report evidence artifact pullrequest github ${IMAGE_NAME} \
             --artifact-type=docker \
             --github-token ${{ secrets.GITHUB_TOKEN }} \
             --name=pull-request