Skip to content

Commit

Permalink
Report Kosli evidence for unit and integration tests separately
Browse files Browse the repository at this point in the history
  • Loading branch information
JonJagger committed Mar 2, 2024
1 parent 7d2624c commit 9158261
Show file tree
Hide file tree
Showing 6 changed files with 39 additions and 40 deletions.
22 changes: 15 additions & 7 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -164,16 +164,24 @@ jobs:
- name: Run tests with branch-coverage
run: |
make test
kosli attest junit "${IMAGE_NAME}" \
--name=runner.unit-test \
--results-dir=./test/server/reports/junit
kosli attest generic "${IMAGE_NAME}" \
--attachments=./test/client/reports \
--attachments=./test/server/reports \
--description="server & client branch-coverage" \
--name=runner.branch-coverage \
--user-data=./test/evidence.json
--name=runner.unit-test-branch-coverage \
--user-data=./test/server/reports/coverage.json
# kosli attest junit "${IMAGE_NAME}"
# --name=runner.unit-test
# --results-dir=./test/server/reports/junit
kosli attest junit "${IMAGE_NAME}" \
--name=runner.integration-test \
--results-dir=./test/client/reports/junit
kosli attest generic "${IMAGE_NAME}" \
--attachments=./test/client/reports \
--name=runner.integration-test-branch-coverage \
--user-data=./test/client/reports/coverage.json
snyk-container-scan:
Expand Down
26 changes: 17 additions & 9 deletions .github/workflows/main_staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ jobs:
echo "kosli_fingerprint=${FINGERPRINT}" >> ${GITHUB_OUTPUT}
unit-tests:
tests:
needs: [wait-for-image, kosli-trail]
runs-on: ubuntu-latest
env:
Expand All @@ -152,16 +152,24 @@ jobs:
- name: Run tests with branch-coverage
run: |
make test
kosli attest junit "${IMAGE_NAME}" \
--name=runner.unit-test \
--results-dir=./test/server/reports/junit
kosli attest generic "${IMAGE_NAME}" \
--attachments=./test/client/reports \
--attachments=./test/server/reports \
--description="server & client branch-coverage" \
--name=runner.branch-coverage \
--user-data=./test/evidence.json
--name=runner.unit-test-branch-coverage \
--user-data=./test/server/reports/coverage.json
kosli attest junit "${IMAGE_NAME}" \
--name=runner.integration-test \
--results-dir=./test/client/reports/junit
# kosli attest junit "${IMAGE_NAME}"
# --name=runner.unit-test
# --results-dir=test/reports/junit
kosli attest generic "${IMAGE_NAME}" \
--attachments=./test/client/reports \
--name=runner.integration-test-branch-coverage \
--user-data=./test/client/reports/coverage.json
snyk-container-scan:
Expand Down Expand Up @@ -241,7 +249,7 @@ jobs:
sdlc-control-gate:
needs: [unit-tests, snyk-container-scan, snyk-code-scan, kosli-trail, wait-for-image]
needs: [tests, snyk-container-scan, snyk-code-scan, kosli-trail, wait-for-image]
runs-on: ubuntu-latest
steps:
- name: Setup Kosli CLI
Expand Down
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ test/client/reports/.*

test/server/reports/*
test/server/reports/.*

test/evidence.json
8 changes: 7 additions & 1 deletion .kosli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ trail:
artifacts:
- name: runner
attestations:
- name: branch-coverage
- name: unit-test
type: junit
- name: unit-test-branch-coverage
type: generic
- name: integration-test
type: junit
- name: integration-test-branch-coverage
type: generic
- name: snyk-container-scan
type: snyk
Expand Down
2 changes: 0 additions & 2 deletions sh/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ source "${SH_DIR}/create_test_data_manifests_file.sh"
source "${SH_DIR}/remove_zombie_containers.sh"
source "${SH_DIR}/setup_dependent_images.sh"
source "${SH_DIR}/test_in_containers.sh"
source "${SH_DIR}/write_evidence_json.sh"

source "${SH_DIR}/echo_versioner_env_vars.sh"
export $(echo_versioner_env_vars)
Expand All @@ -23,4 +22,3 @@ server_up_healthy_and_clean
client_up_healthy_and_clean "$@"
test_in_containers "$@"
containers_down
write_evidence_json "$@"
19 changes: 0 additions & 19 deletions sh/write_evidence_json.sh

This file was deleted.

0 comments on commit 9158261

Please sign in to comment.