Skip to content

Commit

Permalink
When colour==faulty return rag_lambda and error.message in lined format
Browse files Browse the repository at this point in the history
  • Loading branch information
JonJagger committed Jan 16, 2020
1 parent af4b0a5 commit e3b1fd5
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 18 deletions.
10 changes: 5 additions & 5 deletions app/src/traffic_light.rb
Expand Up @@ -24,8 +24,8 @@ def traffic_light(image_name, id, rag_src, stdout, stderr, status)
'image_name' => image_name,
'id' => id,
'info' => 'eval(rag_lambda) raised an exception',
'message' => error.message,
'rag_lambda' => rag_src
'message' => error.message.lines,
'rag_lambda' => rag_src.lines
}
}
end
Expand All @@ -41,8 +41,8 @@ def traffic_light(image_name, id, rag_src, stdout, stderr, status)
'image_name' => image_name,
'id' => id,
'info' => 'rag_lambda.call raised an exception',
'message' => error.message,
'rag_lambda' => rag_src
'message' => error.message.lines,
'rag_lambda' => rag_src.lines
}
}
end
Expand All @@ -54,7 +54,7 @@ def traffic_light(image_name, id, rag_src, stdout, stderr, status)
'image_name' => image_name,
'id' => id,
'info' => "rag_lambda.call is '#{colour}' which is not 'red'|'amber'|'green'",
'rag_lambda' => rag_src
'rag_lambda' => rag_src.lines
}
}
end
Expand Down
26 changes: 13 additions & 13 deletions test_server/feature_traffic_light_test.rb
Expand Up @@ -89,8 +89,8 @@ def self.hex_prefix
assert_equal image_stub, diagnostic['image_name'], :image_name
assert_equal id, diagnostic['id'], :id
assert_equal expected_info, diagnostic['info'], :info
assert diagnostic['message'].start_with?(expected_message), :message
assert_equal stub, diagnostic['rag_lambda'], :rag_lambda
assert diagnostic['message'][0].start_with?(expected_message), :message
assert_equal stub.lines, diagnostic['rag_lambda'], :rag_lambda
end

# - - - - - - - - - - - - - - - - -
Expand All @@ -113,8 +113,8 @@ def self.hex_prefix
assert_equal image_stub, diagnostic['image_name'], :image_name
assert_equal id, diagnostic['id'], :id
assert_equal expected_info, diagnostic['info'], :info
assert_equal expected_message, diagnostic['message'], :message
assert_equal stub, diagnostic['rag_lambda'], :rag_lambda
assert_equal [expected_message], diagnostic['message'], :message
assert_equal stub.lines, diagnostic['rag_lambda'], :rag_lambda
end

# - - - - - - - - - - - - - - - - -
Expand All @@ -137,7 +137,7 @@ def self.hex_prefix
assert_equal id, diagnostic['id'], :id
assert_equal expected_info, diagnostic['info'], :info
assert_nil diagnostic['message'], :message
assert_equal stub, diagnostic['rag_lambda'], :rag_lambda
assert_equal stub.lines, diagnostic['rag_lambda'], :rag_lambda
end

# - - - - - - - - - - - - - - - - -
Expand All @@ -160,8 +160,8 @@ def self.hex_prefix
assert_equal image_stub, diagnostic['image_name'], :image_name
assert_equal id, diagnostic['id'], :id
assert_equal expected_info, diagnostic['info'], :info
assert_equal expected_message, diagnostic['message'], :message
assert_equal stub, diagnostic['rag_lambda'], :rag_lambda
assert_equal [expected_message], diagnostic['message'], :message
assert_equal stub.lines, diagnostic['rag_lambda'], :rag_lambda
end

# - - - - - - - - - - - - - - - - -
Expand All @@ -184,8 +184,8 @@ def self.hex_prefix
assert_equal image_stub, diagnostic['image_name'], :image_name
assert_equal id, diagnostic['id'], :id
assert_equal expected_info, diagnostic['info'], :info
assert_equal expected_message, diagnostic['message'], :message
assert_equal stub, diagnostic['rag_lambda'], :rag_lambda
assert_equal [expected_message], diagnostic['message'], :message
assert_equal stub.lines, diagnostic['rag_lambda'], :rag_lambda
end

# - - - - - - - - - - - - - - - - -
Expand All @@ -203,8 +203,8 @@ def self.hex_prefix
assert_equal image_stub, diagnostic['image_name'], :image_name
assert_equal id, diagnostic['id'], :id
assert_equal expected_info, diagnostic['info'], :info
assert diagnostic['message'].include?(expected_message), :message
assert_equal stub, diagnostic['rag_lambda'], :rag_lambda
assert diagnostic['message'][0].include?(expected_message), :message
assert_equal stub.lines, diagnostic['rag_lambda'], :rag_lambda
end

# - - - - - - - - - - - - - - - - -
Expand All @@ -222,8 +222,8 @@ def self.hex_prefix
assert_equal image_stub, diagnostic['image_name'], :image_name
assert_equal id, diagnostic['id'], :id
assert_equal expected_info, diagnostic['info'], :info
assert_equal expected_message, diagnostic['message'], :message
assert_equal stub, diagnostic['rag_lambda'], :rag_lambda
assert_equal [expected_message], diagnostic['message'], :message
assert_equal stub.lines, diagnostic['rag_lambda'], :rag_lambda
end

private
Expand Down

0 comments on commit e3b1fd5

Please sign in to comment.