Skip to content

Commit

Permalink
Fix typo in CI env-var
Browse files Browse the repository at this point in the history
  • Loading branch information
JonJagger committed Aug 20, 2022
1 parent e9016a5 commit bf6d08b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 11 deletions.
14 changes: 5 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,13 @@

Development
-----------
To build the images, bring up the containers, and wait till they are alive and healthy:
To build the images, bring up the containers, and wait till they are alive and healthy, and run the tests:
```bash
$ ./build.sh && ./up.sh && ./wait.sh
````

To run the tests:
```bash
$ ./test.sh --help
$ ./build_test_publish.sh
```

```
Use: ./test.sh [server|client] [ID...]
Use: ./build_test_publish.sh [server|client] [ID...]
No options runs all server tests, then all client tests
Expand All @@ -29,7 +25,7 @@ Options:
-h|--help show this help
```

* The [build.sh](build.sh) script (re)creates [docker-compose.yml](docker-compose.yml)
* The [scripts/build.sh](scripts/build.sh) script (re)creates [docker-compose.yml](docker-compose.yml)
* In [docker-compose.yml](docker-compose.yml), the source and test dirs are volume-mounted over their image counterparts.
* These overlays keeps the dev-cycle fast by reducing the need to build/up/wait.
* You need to build/up/wait when:
Expand Down
2 changes: 1 addition & 1 deletion build_test_publish.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ fi
./build.sh
./up.sh
./wait.sh
./test.sh
./test.sh "$@"

if ! on_ci; then
echo Not on CI, so not pushing image, not logging to Kosli
Expand Down
2 changes: 1 addition & 1 deletion scripts/kosli_echo_env_vars.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ kosli_echo_env_vars()
echo MERKELY_PIPELINE=saver

echo CI_BUILD_NUM=${GITHUB_RUN_NUMBER}
echo CI_BUIL_URL=${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}
echo CI_BUILD_URL=${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}
}

0 comments on commit bf6d08b

Please sign in to comment.