Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to 1.17 and run go mod tidy #121

Merged
merged 1 commit into from Dec 16, 2021
Merged

Upgrade to 1.17 and run go mod tidy #121

merged 1 commit into from Dec 16, 2021

Conversation

andytinkham
Copy link
Contributor

Signed-off-by: Andy Tinkham andy.tinkham@cyberark.com

Desired Outcome

Upgrade Go to 1.17 & clean up go.mod

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@andytinkham andytinkham requested a review from a team as a code owner December 15, 2021 22:45
@andytinkham
Upgrade to 1.17 and run go mod tidy
3b7fd01 
Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
szh
szh approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andytinkham andytinkham merged commit 46d741e into main Dec 16, 2021
@andytinkham andytinkham deleted the update-net-module branch December 16, 2021 15:31
szh added a commit that referenced this pull request May 13, 2022
@szh
Remove Golang 1.16 from CI, replace with 1.18
ef6739d 
Golang 1.16 support was removed in #121 but
remained in the CI. This commit removes
it and adds 1.18 as an additional tested version
@szh szh mentioned this pull request May 13, 2022
Merged
13 tasks
szh added a commit that referenced this pull request May 13, 2022
@szh
Remove Golang 1.16 from CI, replace with 1.18
de78abd 
Golang 1.16 support was removed in #121 but
remained in the CI. This commit removes
it and adds 1.18 as an additional tested version
szh added a commit that referenced this pull request May 13, 2022
@szh
Remove Golang 1.16 from CI, replace with 1.18
a84c261 
Golang 1.16 support was removed in #121 but
remained in the CI. This commit removes
it and adds 1.18 as an additional tested version
szh added a commit that referenced this pull request May 13, 2022
@szh
Remove Golang 1.16 from CI, replace with 1.18
97ef34f 
Golang 1.16 support was removed in #121 but
remained in the CI. This commit removes
it and adds 1.18 as an additional tested version
szh added a commit that referenced this pull request May 13, 2022
@szh
Remove Golang 1.16 from CI, replace with 1.18
2c202b0 
Golang 1.16 support was removed in #121 but
remained in the CI. This commit removes
it and adds 1.18 as an additional tested version
@john-odonnell john-odonnell mentioned this pull request May 17, 2022
Merged
szh added a commit that referenced this pull request Aug 19, 2022
@szh
Remove Golang 1.16 from CI, replace with 1.18
87b6cd4 
Golang 1.16 support was removed in #121 but
remained in the CI. This commit removes
it and adds 1.18 as an additional tested version
szh added a commit that referenced this pull request Aug 19, 2022
@szh
Remove Golang 1.16 from CI, replace with 1.18
8ed391e 
Golang 1.16 support was removed in #121 but
remained in the CI. This commit removes
it and adds 1.18 as an additional tested version
szh added a commit that referenced this pull request Aug 19, 2022
@szh
Remove Golang 1.16 from CI, replace with 1.18
2459423 
Golang 1.16 support was removed in #121 but
remained in the CI. This commit removes
it and adds 1.18 as an additional tested version
szh added a commit that referenced this pull request Aug 19, 2022
@szh
Remove Golang 1.16 from CI, replace with 1.18
dd07c3d 
Golang 1.16 support was removed in #121 but
remained in the CI. This commit removes
it and adds 1.18 as an additional tested version
szh added a commit that referenced this pull request Aug 19, 2022
@szh
Remove Golang 1.16 from CI, replace with 1.18
a4f6816 
Golang 1.16 support was removed in #121 but
remained in the CI. This commit removes
it and adds 1.18 as an additional tested version
szh added a commit that referenced this pull request Aug 19, 2022
@szh
Remove Golang 1.16 from CI, replace with 1.18
0cdb7fe 
Golang 1.16 support was removed in #121 but
remained in the CI. This commit removes
it and adds 1.18 as an additional tested version
szh added a commit that referenced this pull request Aug 19, 2022
@szh
Remove Golang 1.16 from CI, replace with 1.18
22d074d 
Golang 1.16 support was removed in #121 but
remained in the CI. This commit removes
it and adds 1.18 as an additional tested version
@gl-johnson gl-johnson mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szh szh szh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andytinkham @szh