Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade yaml.v3 indirect dependency and Dockerfile to golang:1.19.5 #158

Merged
merged 2 commits into from Jan 26, 2023

Conversation

gl-johnson
Copy link
Contributor

@gl-johnson gl-johnson commented Jan 25, 2023

Desired Outcome

  • Upgrade yaml.v3 indirect versions to 3.0.1 (via replace statement)
  • Upgrade dockerfile to golang:1.19
  • Add 1.19 testing to pipeline

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@gl-johnson gl-johnson marked this pull request as ready for review January 26, 2023 00:10
@gl-johnson gl-johnson requested a review from a team as a code owner January 26, 2023 00:10
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop Go 1.17 since it's EOL

@codeclimate
Copy link

codeclimate bot commented Jan 26, 2023

Code Climate has analyzed commit dd8c4ad and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.2% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gl-johnson gl-johnson merged commit cc53387 into main Jan 26, 2023
@gl-johnson gl-johnson deleted the upgrade-yaml-v3 branch January 26, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants