Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with hostfactory requiring the fully qualified host factory id #164

Merged
merged 1 commit into from Feb 15, 2023

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Feb 14, 2023

Desired Outcome

Hostfactory should not require the fully qualified host factory id

Implemented Changes

This inserts the account and host_factory portion of the host factory id

Connected Issue/Story

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

conjurapi/host_factory.go Outdated Show resolved Hide resolved
@rpothier rpothier force-pushed the fix-hostfactory-id branch 2 times, most recently from 20bded8 to 997d318 Compare February 14, 2023 20:28
@codeclimate
Copy link

codeclimate bot commented Feb 14, 2023

Code Climate has analyzed commit a1f235a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.6% (0.0% change).

View more on Code Climate.

@rpothier rpothier marked this pull request as ready for review February 14, 2023 22:30
@rpothier rpothier requested a review from a team as a code owner February 14, 2023 22:30
@jtuttle jtuttle merged commit 1080ee2 into main Feb 15, 2023
@szh szh deleted the fix-hostfactory-id branch February 15, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants