Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions for API key rotation now support fully-qualified IDs #166

Merged
merged 1 commit into from Feb 17, 2023

Conversation

john-odonnell
Copy link
Contributor

@john-odonnell john-odonnell commented Feb 16, 2023

Desired Outcome

Allow fully-qualified IDs to be passed to client.RotateUserAPIKey() and client.RotateHostAPIKey().

Implemented Changes

API Key rotation functions use new client.parseIDandEnforceKind(resourceID, kind string) function to accept and parse both fully- and partially-qualified role IDs while enforcing a kind requirement.

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@john-odonnell john-odonnell requested a review from a team as a code owner February 16, 2023 23:40
@john-odonnell john-odonnell force-pushed the rotate-api-key-fully-qualified-support branch from 42e7dde to c94a28e Compare February 16, 2023 23:44
@john-odonnell john-odonnell force-pushed the rotate-api-key-fully-qualified-support branch from c94a28e to ac30724 Compare February 16, 2023 23:53
@codeclimate
Copy link

codeclimate bot commented Feb 16, 2023

Code Climate has analyzed commit ac30724 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.9% (0.3% change).

View more on Code Climate.

Copy link
Contributor

@rpothier rpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@john-odonnell john-odonnell merged commit a059d3d into main Feb 17, 2023
@john-odonnell john-odonnell deleted the rotate-api-key-fully-qualified-support branch February 17, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants