Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Snyk issues #175

Merged
merged 2 commits into from May 23, 2023
Merged

Address Snyk issues #175

merged 2 commits into from May 23, 2023

Conversation

juniortaeza
Copy link
Contributor

@juniortaeza juniortaeza commented May 23, 2023

Desired Outcome

This pull request addresses the Snyk issues outlined in this repository.

Implemented Changes

  • upgrades Go to 1.20 in Dockerfile
  • upgrades golang.org/x/sys to v0.8.0 in go.mod and go.sum

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@juniortaeza juniortaeza requested a review from a team as a code owner May 23, 2023 16:51
@codeclimate
Copy link

codeclimate bot commented May 23, 2023

Code Climate has analyzed commit 986048c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.5% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juniortaeza juniortaeza merged commit c30d303 into main May 23, 2023
4 checks passed
@john-odonnell john-odonnell deleted the snyk-issues-branch branch May 30, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants