Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ruby 3.0.2 #197

Merged
merged 14 commits into from
Dec 9, 2021
Merged

Support ruby 3.0.2 #197

merged 14 commits into from
Dec 9, 2021

Conversation

semyon-estrin
Copy link
Contributor

@semyon-estrin semyon-estrin commented Dec 7, 2021

Desired Outcome

Conjur-api-ruby is running on ruby-3.0.2.

Implemented Changes

Changed default ruby version to 3.0.2.

Changed necessary code segments to adjust for ruby-3.0.2:

  • Default parameters behavior in ruby 3.0.2 changed comparing to 2.X.X, when default value is nil.
  • URI.escape is deprecated starting ruby-2.7, replaced with Addressable::URI.escape

Connected Issue/Story

CyberArk internal issue link: insert issue ID

Definition of Done

Tests are green with ruby-3.0.2.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@semyon-estrin semyon-estrin self-assigned this Dec 7, 2021
@semyon-estrin semyon-estrin changed the title Upgrade conjur-api-ruby to ruby-3.0.2 Upgrade to ruby 3.0.2 Dec 7, 2021
Jenkinsfile Outdated Show resolved Hide resolved
@semyon-estrin semyon-estrin changed the title Upgrade to ruby 3.0.2 Support ruby 3.0.2 Dec 8, 2021
Copy link
Contributor

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments
Pay attention on backward compatibility issues

Jenkinsfile Outdated Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
lib/conjur/base.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeclimate
Copy link

codeclimate bot commented Dec 9, 2021

Code Climate has analyzed commit ce2dd19 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 83.9% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants