Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressable gem dependency update #199

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Addressable gem dependency update #199

merged 3 commits into from
Dec 13, 2021

Conversation

semyon-estrin
Copy link
Contributor

@semyon-estrin semyon-estrin commented Dec 12, 2021

Desired Outcome

Addressable dependency changed from (~> 2.8.0) to (~2.0) to allow compatability with other gems in conjur.

Implemented Changes

Change dependency in conjur-api.gemspec

Connected Issue/Story

CyberArk internal issue link: ONYX-14705

Definition of Done

Same addressable version (2.8.0) is used within conjur-api-ruby.
Dependency changed to (~> 2.0).
Jenkins CI tests are green.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@semyon-estrin semyon-estrin changed the title Ease on addressable gem version constrain Addressable gem dependency update Dec 13, 2021
@semyon-estrin semyon-estrin self-assigned this Dec 13, 2021
Copy link
Contributor

@sashaCher sashaCher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semyon-estrin semyon-estrin marked this pull request as ready for review December 13, 2021 21:12
@semyon-estrin semyon-estrin requested a review from a team as a code owner December 13, 2021 21:12
@codeclimate
Copy link

codeclimate bot commented Dec 13, 2021

Code Climate has analyzed commit 908241e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 83.9% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants