Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when using self-signed certificate #119

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

szh
Copy link
Contributor

@szh szh commented Mar 27, 2023

Desired Outcome

Conjur CLI message when not using --self-signed with self signed cert should be improved

Implemented Changes

  • In the init command, if there's an error retrieving or validating the server certificate, and the --self-signed flag is not provided, print "If you're attempting to use a self-signed certificate, re-run the init command with the --self-signed flag"

Connected Issue/Story

CyberArk internal issue ID: CNJR-506

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this Mar 27, 2023
@szh szh force-pushed the self-signed-msg branch 3 times, most recently from 38458ed to 925bb0a Compare March 27, 2023 19:25
@szh szh marked this pull request as ready for review March 27, 2023 19:27
@szh szh requested a review from a team as a code owner March 27, 2023 19:27
CHANGELOG.md Show resolved Hide resolved
@szh szh requested a review from adamouamani March 27, 2023 19:38
@codeclimate
Copy link

codeclimate bot commented Mar 27, 2023

Code Climate has analyzed commit 2c6bf5b and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 81.0% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@doodlesbykumbi doodlesbykumbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had other comments. LGTM just a clarification comment

Comment on lines -26 to +27
- ../conf/:/etc/nginx/conf.d/:ro
- ../conf/tls/:/etc/nginx/tls/:ro
- ./conf/:/etc/nginx/conf.d/:ro
- ./conf/tls/:/etc/nginx/tls/:ro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm this is to capture the idea that this docker-compose environment is only ever run with the working directory set to where the docker-compose.yml file is ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. This is used in the CI script and this path was incorrect to begin with from what I can tell. I only realized it when I tried to use the proxy service in the course of testing.

@szh szh merged commit be0bfde into master Mar 29, 2023
@szh szh deleted the self-signed-msg branch March 29, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants