Support non-TTY Stdin for Confirmation prompts #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-odonnell
force-pushed
the
confirm-prompt-bugfix
branch
3 times, most recently
from
b09bd2b
to
9299947
Compare
gl-johnson
reviewed
Apr 19, 2023
| ## [8.0.8] - 2023-04-19 | ||
|
|
||
| ### Fixed | ||
| - Fixed piping input to `conjur init` confirmation prompts |
There was a problem hiding this comment.
May be worth checking with @szh if he will be re-releasing v8.0.7 with this fix
There was a problem hiding this comment.
I released 8.0.7 yesterday but am hoping to squeeze in 8.0.0 if I can before the end of the week
john-odonnell
force-pushed
the
confirm-prompt-bugfix
branch
from
9299947
to
066a6dc
Compare
Being unable to pipe responses to prompts is a known shortcoming of Survey: AlecAivazis/survey#394. We frequently pipe 'yes' responses to CLI confirmation prompts, and this commit supports ONLY those cases.
john-odonnell
force-pushed
the
confirm-prompt-bugfix
branch
from
066a6dc
to
f0eedb4
Compare
|
Code Climate has analyzed commit f0eedb4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 81.4% (0.0% change). View more on Code Climate. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Being unable to pipe responses to prompts is a known shortcoming of Survey: AlecAivazis/survey#394. We frequently pipe 'yes' responses to CLI confirmation prompts, and this commit supports ONLY those cases.
Implemented Changes
func basicConfirm(message string) bool, which uses standardfmtfunctions to prompt and collect confirmation responses.Connected Issue/Story
N/A
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security