Add some DAP endpoints to spec file #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telday
force-pushed
the
test-transform
branch
11 times, most recently
from
92cd761
to
c842285
Compare
telday
force-pushed
the
test-transform
branch
18 times, most recently
from
87df6c0
to
5cf2653
Compare
telday
force-pushed
the
test-transform
branch
2 times, most recently
from
56aca51
to
b22afaf
Compare
izgeri
suggested changes
Mar 29, 2021
izgeri
reviewed
Mar 29, 2021
telday
force-pushed
the
test-transform
branch
2 times, most recently
from
fc6708b
to
ebb9c3d
Compare
izgeri
previously approved these changes
Apr 13, 2021
Also added python integration tests for the three added endpoints. /health /remote_health /info
Also removed contract test and linting from Jenkins pipeline. They are always run in github actions so having them in Jenkins is redundant. We only need the integration tests to run in Jenkins for test artifacts/coverage reporting.
Run the local script in place of manually performing the linting steps in a GitHub action. This should make sure linting checks locally match CI
izgeri
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds some of the DAP endpoints to the OpenAPI spec and adds integration tests for the new endpoints as well as infrastructure to run them.
In the name of minimizing the amount of time spent on this one PR I have excluded two things which issues should be opened to add later:
configuration/{account}/seed/followerendpointBefore the Jenkins CI tests will run properly this PR on dap-intro needs to be merged in.Follow up issues:
What ticket does this PR close?
Resolves #144
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or