Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new route for enabling authenticator with default service #215

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Add new route for enabling authenticator with default service #215

merged 2 commits into from
Dec 22, 2021

Conversation

aloncarmel111
Copy link
Contributor

Desired Outcome

Add new route for enabling authenticator with default service

Connected Issue/Story

Resolves #ONYX-13302

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@aloncarmel111 aloncarmel111 requested a review from a team as a code owner December 21, 2021 22:44
@aloncarmel111 aloncarmel111 force-pushed the enable-authenticator branch 2 times, most recently from d79944f to 8e984c1 Compare December 22, 2021 08:10
@szh szh merged commit 082e7a3 into main Dec 22, 2021
@szh szh deleted the enable-authenticator branch December 22, 2021 14:05
@john-odonnell john-odonnell mentioned this pull request Jul 8, 2022
Merged
@gl-johnson gl-johnson mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netacoral netacoral netacoral approved these changes

@uCatu uCatu Awaiting requested review from uCatu

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aloncarmel111 @netacoral @szh