Adds Generated Ruby Client Example #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgnn7
reviewed
Nov 25, 2020
There was a problem hiding this comment.
@john-odonnell Great work on this! I left some comments but it seems pretty straightforward good addition!
john-odonnell
force-pushed
the
more-examples
branch
from
9a94331
to
e574030
Compare
sgnn7
reviewed
Nov 30, 2020
There was a problem hiding this comment.
@john-odonnell Code is looking great - just a few more comments!
john-odonnell
force-pushed
the
more-examples
branch
3 times, most recently
from
b2daa60
to
b2a637b
Compare
BradleyBoutcher
suggested changes
Dec 2, 2020
john-odonnell
force-pushed
the
more-examples
branch
from
b2a637b
to
ee2e328
Compare
6 tasks
john-odonnell
force-pushed
the
more-examples
branch
2 times, most recently
from
d166eb4
to
bf780f2
Compare
john-odonnell
force-pushed
the
more-examples
branch
from
bf780f2
to
7270568
Compare
BradleyBoutcher
suggested changes
Dec 3, 2020
john-odonnell
force-pushed
the
more-examples
branch
2 times, most recently
from
55f4965
to
4bd77d3
Compare
Adds localhost as a Subject Alternative Name on leafnode certificates. Allows SSL verification on local Conjur instances. Updates Python client demo to use HTTPS.
Previously, the policies were defined in the example. Moving their definition to independent files will allow multiple examples to use the same policies in their workflows.
Demonstrates the same API endpoints as the Python example: - authentication - password change - policy load - API key rotation of foreign role - secret storage and retrieval
john-odonnell
force-pushed
the
more-examples
branch
from
4bd77d3
to
39ee1cd
Compare
john-odonnell
changed the title
john-odonnell
force-pushed
the
more-examples
branch
2 times, most recently
from
81d542b
to
3ab960d
Compare
john-odonnell
changed the title
Adds unique READMEs to each example, and generalizes terminology in project main README regarding examples. Updates CHANGELOG.
Python exits on exceptions. Removing these blocks simplify the example, and provide more extensive error messages if an exception does occur.
Done to eliminate the need for a user to install RVM before using the example. This change includes the following: - Adds a ruby-example service to the project's docker-compose - Adds Dockerfile for building the ruby-example service - Updates to the Ruby example program and start script to account for these changes - Updates to start_conjur, integration_tests, and GHActions integration test workflow - These processes now build only the docker-compose services they require - GHAction workflow uses integration_tests script, reducing duplicate code - Documentation regarding the examples are updated across the project
Script originally discarded output from other scripts, like generate_client and start_conjur. Redirection was limited to stdout, allowing stderr to display.
john-odonnell
force-pushed
the
more-examples
branch
from
3ab960d
to
875dadb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an example which uses a spec-generated Ruby client.
The example is similar in workflow to the existing Python client example.
Updates certificates to include
localhostas a leafnode SAN, allows SSL verification againstlocal Conjur instances.
What ticket does this PR close?
Closes #12
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or