Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Conjur CLI v8.0 #179

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Use Conjur CLI v8.0 #179

merged 1 commit into from
Mar 9, 2023

Conversation

szh
Copy link
Contributor

@szh szh commented Feb 23, 2023

Desired Outcome

Update helm chart notices to use CLI v8.0.

Implemented Changes

Updated README.md and conjur-oss/templates/NOTES.txt to refer to the v8 Conjur CLI tag and use the updated command syntax.
Updated CHANGELOG.md in preparation for new release of the helm chart, v2.0.6.

Connected Issue/Story

Resolves #178

CyberArk internal issue ID: ONYX-33379

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this Feb 23, 2023
@szh szh force-pushed the cli8 branch 5 times, most recently from 73cdf22 to 394e820 Compare March 8, 2023 19:48
@szh szh marked this pull request as ready for review March 8, 2023 19:48
@szh szh requested a review from a team as a code owner March 8, 2023 19:48
@szh szh force-pushed the cli8 branch 2 times, most recently from f1e3516 to 242d029 Compare March 8, 2023 19:55
@szh szh mentioned this pull request Mar 8, 2023
@szh szh force-pushed the cli8 branch 8 times, most recently from 72442d3 to 596a9d9 Compare March 8, 2023 21:40
Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the scripts in the examples dir rely on other scripts in kubernetes-conjur-demo, which still uses on the old CLI. Pushing the CLI image to the local registry fails, but that seems like a separate issue altogether.

++++++++++++++++++++++++++++++++++++++

Pulling and pushing Conjur CLI image.

++++++++++++++++++++++++++++++++++++++
5-latest: Pulling from cyberark/conjur-cli
Digest: sha256:c61703c5fc62fd3452564c69b379a48e878f6481fd9404c041c73230e6a92613
Status: Image is up to date for cyberark/conjur-cli:5-latest
docker.io/cyberark/conjur-cli:5-latest
The push refers to repository [localhost:5000/conjur-cli]
Get "http://localhost:5000/v2/": net/http: request canceled (Client.Timeout exceeded while awaiting headers)

@szh
Copy link
Contributor Author

szh commented Mar 9, 2023

Yes, I'm working on that already :)

@szh szh merged commit d45783a into main Mar 9, 2023
@szh szh deleted the cli8 branch March 9, 2023 19:15
@szh szh mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Update the Helm chart instructions to use the new Conjur CLI
2 participants