Add support for JWT tokens #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not clear what was the intent behind this method, but there is no documentation and no usage as far as I can tell.
Split Authenticator and .user spec, make -fdoc more readable.
While this might move the tests a bit on the unit-integration spectrum, it does make them more realistic and easier to implement. Specific things can still be mocked and stubbed as needed for test granularity.
Please refer to cyberark/slosilo#10 for details.
Closes #11.
dividedmind
force-pushed
the
feature/jwt
branch
from
2b4b8cc
to
b33153d
Compare
JWT lacks a mechanism for specifying critical claims as JWS has with header 'crit' field; JWT spec suggests to ignore unrecognized claims and that is what a generic JWT library should do. However, conjur-rack is a specific application; for security reasons it's best to reject tokens which we don't totally understand, lest the requester is allowed to do what she is not in fact authorized to. If need be, this can be extended in the future with 'crit'-like mechanism for specifying optional claims. Related: cyberark/slosilo#12
|
Can be merged in after cyberark/slosilo#11 is. Note Gemfile should be edited to remove the slosilo branch indication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cyberark/slosilo#10 for details. Note this changeset includes #9.