Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Remove support for Ruby 2.5 and 2.6 #351

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Remove support for Ruby 2.5 and 2.6 #351

merged 2 commits into from
Mar 31, 2022

Conversation

szh
Copy link
Contributor

@szh szh commented Mar 31, 2022

Desired Outcome

According to https://endoflife.date/ruby, Ruby 2.5 and 2.6 are end-of-life. This PR removes CI tests on these version.
Additionally, this PR updates the Github certificate we use in testing because Github has updated their certificate.

Implemented Changes

  • Removed CI tests on Ruby version 2.5 and 2.6
  • Updated GH cert and fingerprint

Connected Issue/Story

N/A

Definition of Done

  • Jenkins passes

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this Mar 31, 2022
@szh szh changed the title Remove support for Ruby 2.5 Remove support for Ruby 2.5 and 2.6 Mar 31, 2022
@szh szh marked this pull request as ready for review March 31, 2022 14:21
@szh szh requested a review from a team as a code owner March 31, 2022 14:21
Copy link
Contributor

@rpothier rpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants