deploy scripts support Conjur v5 enterprise #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dustinmm80
reviewed
Aug 1, 2018
README.md
Outdated
| @@ -10,9 +10,19 @@ environment variables. The setup instructions below walk you through the | |||
| necessary steps for configuring your environment and show you which variables | |||
| need to be set before deploying. | |||
|
|
|||
| ### Conjur Version | |||
|
|
|||
| If you are workign with Conjur v4, you will need to set: | |||
There was a problem hiding this comment.
little typo here: workign
dustinmm80
reviewed
Aug 1, 2018
kubernetes/conjur-cluster.yaml
Outdated
| env: | ||
| # Only required for Conjur v5 | ||
| - name: CONJUR_DATA_KEY | ||
| value: "{{ DATA_KEY }}" |
There was a problem hiding this comment.
any reason not to call this var CONJUR_DATA_KEY as well? more explicit when you see it in scripts, i think
There was a problem hiding this comment.
Nope, that works. Will change it.
jtuttle
force-pushed
the
16--deploy-scripts-support-conjur-v5-enterprise
branch
from
7439e46
to
a518c45
Compare
jtuttle
force-pushed
the
16--deploy-scripts-support-conjur-v5-enterprise
branch
from
a518c45
to
29e175f
Compare
|
We need a few more things before we can merge:
Once these are done we're all set to squash/merge. |
added 5 commits
August 1, 2018 13:15
…hub.com:cyberark/kubernetes-conjur-deploy into 16--deploy-scripts-support-conjur-v5-enterprise
dustinmm80
reviewed
Aug 2, 2018
8_print_config.sh
Outdated
| @@ -6,10 +6,16 @@ set -euo pipefail | |||
| set_namespace $CONJUR_NAMESPACE_NAME | |||
|
|
|||
| if [ $PLATFORM = 'kubernetes' ]; then | |||
| ui_url="https://$(get_master_service_ip):443" | |||
| ui_url="https://$(get_master_service_ip):443" | |||
There was a problem hiding this comment.
any reason to add 443 on the end here? if it's https:// prefix it's 443 by default. Looks a bit weird in output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16