Fixed garbled logging messages in PG connector

Some of the messages were using the non-formatted output with a formatting string which was creating pretty unreadable logging output so these have been fixed now.
cyberark · Apr 9, 2020 · 2fd6b3e · 2fd6b3e
1 parent 69b1ade
commit 2fd6b3e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/internal/plugin/connectors/tcp/pg/backend.go b/internal/plugin/connectors/tcp/pg/backend.go
@@ -105,7 +105,7 @@ func (s *SingleUseConnector) ConnectToBackend() error {
 		return err
 	}
 
-	s.logger.Debugln(
+	s.logger.Debugf(
 		"Successfully connected to '%s:%s'",
 		s.connectionDetails.Host,
 		s.connectionDetails.Port,

diff --git a/internal/plugin/connectors/tcp/pg/startup.go b/internal/plugin/connectors/tcp/pg/startup.go
@@ -9,7 +9,7 @@ import (
 // Startup performs the startup handshake with the client and parses the client
 // options to extract the database name.
 func (s *SingleUseConnector) Startup() error {
-	s.logger.Debugln("Handling connection %v", s.clientConn)
+	s.logger.Debugf("Handling connection %+v -> %+v", s.clientConn.RemoteAddr(), s.clientConn.LocalAddr())
 
 	messageBytes, err := protocol.ReadStartupMessage(s.clientConn)
 	if err != nil {
@@ -21,8 +21,8 @@ func (s *SingleUseConnector) Startup() error {
 		return err
 	}
 
-	s.logger.Debugln(
-		"s.Client version : %v, (SSL mode: %v)",
+	s.logger.Debugf(
+		"s.Client version: %v, (SSL mode: %v)",
 		version,
 		version == protocol.SSLRequestCode)