MSSQL connector OK message has tests against different protocol and server versions #1017
Closed
1 task done
Comments
izgeri
changed the title
diverdane
pushed a commit
that referenced
this issue
Dec 18, 2019
This test extends the MSSQL integration tests by adding test for running the existing test suite against the following MSSQL server versions: - 2019-latest - 2017-CU1-ubuntu in addition to the `2017-latest` version that is used in the existing test. Addresses serverless-broker Issue #1017.
diverdane
pushed a commit
that referenced
this issue
Dec 18, 2019
This test extends the MSSQL integration tests by adding test for running the existing test suite against the following MSSQL server versions: - 2019-latest - 2017-CU1-ubuntu in addition to the `2017-latest` version that is used in the existing test. Addresses serverless-broker Issue #1017.
diverdane
pushed a commit
that referenced
this issue
Dec 18, 2019
This test extends the MSSQL integration tests by adding test for running the existing test suite against the following MSSQL server versions: - 2019-latest - 2017-CU1-ubuntu in addition to the `2017-latest` version that is used in the existing test. Addresses serverless-broker Issue #1017.
diverdane
pushed a commit
that referenced
this issue
Dec 20, 2019
This test extends the MSSQL integration tests by adding test for running the existing test suite against the following MSSQL server versions: - 2019-latest - 2017-CU1-ubuntu in addition to the `2017-latest` version that is used in the existing test. The integration tests for each new server version have been added in their own subdirectory in the MSSQL test directory. This will allow for different server versions to be incrementally added/removed over time without affecting the default testing that uses MSSQL server version 2017-latest. Each MSSQL server version test subdirectory has its own versions of docker-compose.yml and secretless.yml that use different values of host ports for the various services so that they can run concurrently. Each subdirectory also has versions of the 'start', 'stop', 'test', 'test-local', and 'wait_for_mssql' scripts, but these scripts mostly delegate to their counterparts in the parent test directory (so that any changes to scripts in the parent directory will not have to be duplicated in the subdirectories). Addresses serverless-broker Issue #1017.
diverdane
pushed a commit
that referenced
this issue
Dec 20, 2019
This test extends the MSSQL integration tests by adding test for running the existing test suite against the following MSSQL server versions: - 2019-latest - 2017-CU1-ubuntu in addition to the `2017-latest` version that is used in the existing test. The integration tests for each new server version have been added in their own subdirectory in the MSSQL test directory. This will allow for different server versions to be incrementally added/removed over time without affecting the default testing that uses MSSQL server version 2017-latest. Each MSSQL server version test subdirectory has its own versions of docker-compose.yml and secretless.yml that use different values of host ports for the various services so that they can run concurrently. Each subdirectory also has versions of the 'start', 'stop', 'test', 'test-local', and 'wait_for_mssql' scripts, but these scripts mostly delegate to their counterparts in the parent test directory (so that any changes to scripts in the parent directory will not have to be duplicated in the subdirectories). Addresses serverless-broker Issue #1017.
diverdane
pushed a commit
that referenced
this issue
Dec 20, 2019
This test extends the MSSQL integration tests by adding test for running the existing test suite against the following MSSQL server versions: - 2019-latest - 2017-CU1-ubuntu in addition to the `2017-latest` version that is used in the existing test. The integration tests for each new server version have been added in their own subdirectory in the MSSQL test directory. This will allow for different server versions to be incrementally added/removed over time without affecting the default testing that uses MSSQL server version 2017-latest. Each MSSQL server version test subdirectory has its own versions of docker-compose.yml and secretless.yml that use different values of host ports for the various services so that they can run concurrently. Each subdirectory also has versions of the 'start', 'stop', 'test', 'test-local', and 'wait_for_mssql' scripts, but these scripts mostly delegate to their counterparts in the parent test directory (so that any changes to scripts in the parent directory will not have to be duplicated in the subdirectories). Addresses serverless-broker Issue #1017.
diverdane
pushed a commit
that referenced
this issue
Dec 20, 2019
This test extends the MSSQL integration tests by adding test for running the existing test suite against the following MSSQL server versions: - 2019-latest - 2017-CU1-ubuntu in addition to the `2017-latest` version that is used in the existing test. The integration tests for each new server version have been added in their own subdirectory in the MSSQL test directory. This will allow for different server versions to be incrementally added/removed over time without affecting the default testing that uses MSSQL server version 2017-latest. Each MSSQL server version test subdirectory has its own versions of docker-compose.yml and secretless.yml that use different values of host ports for the various services so that they can run concurrently. Each subdirectory also has versions of the 'start', 'stop', 'test', 'test-local', and 'wait_for_mssql' scripts, but these scripts mostly delegate to their counterparts in the parent test directory (so that any changes to scripts in the parent directory will not have to be duplicated in the subdirectories). Addresses serverless-broker Issue #1017.
diverdane
pushed a commit
that referenced
this issue
Dec 20, 2019
This test extends the MSSQL integration tests by adding test for running the existing test suite against the following MSSQL server versions: - 2019-latest - 2017-CU1-ubuntu in addition to the `2017-latest` version that is used in the existing test. The integration tests for each new server version have been added in their own subdirectory in the MSSQL test directory. This will allow for different server versions to be incrementally added/removed over time without affecting the default testing that uses MSSQL server version 2017-latest. Each MSSQL server version test subdirectory has its own versions of docker-compose.yml and secretless.yml that use different values of host ports for the various services so that they can run concurrently. Each subdirectory also has versions of the 'start', 'stop', 'test', 'test-local', and 'wait_for_mssql' scripts, but these scripts mostly delegate to their counterparts in the parent test directory (so that any changes to scripts in the parent directory will not have to be duplicated in the subdirectories). Addresses serverless-broker Issue #1017.
diverdane
pushed a commit
that referenced
this issue
Dec 23, 2019
This test extends the MSSQL integration tests by adding test for running the existing test suite against the following MSSQL server versions: - 2019-latest - 2017-CU1-ubuntu in addition to the `2017-latest` version that is used in the existing test. The integration tests for each new server version have been added in their own subdirectory in the MSSQL test directory. This will allow for different server versions to be incrementally added/removed over time without affecting the default testing that uses MSSQL server version 2017-latest. Each MSSQL server version test subdirectory has its own versions of docker-compose.yml and secretless.yml that use different values of host ports for the various services so that they can run concurrently. Each subdirectory also has versions of the 'start', 'stop', 'test', 'test-local', and 'wait_for_mssql' scripts, but these scripts mostly delegate to their counterparts in the parent test directory (so that any changes to scripts in the parent directory will not have to be duplicated in the subdirectories). Addresses serverless-broker Issue #1017.
diverdane
pushed a commit
that referenced
this issue
Dec 23, 2019
This test extends the MSSQL integration tests by adding test for running the existing test suite against the following MSSQL server versions: - 2019-latest - 2017-CU1-ubuntu in addition to the `2017-latest` version that is used in the existing test. The integration tests for each new server version have been added in their own subdirectory in the MSSQL test directory. This will allow for different server versions to be incrementally added/removed over time without affecting the default testing that uses MSSQL server version 2017-latest. Each MSSQL server version test subdirectory has its own versions of docker-compose.yml and secretless.yml that use different values of host ports for the various services so that they can run concurrently. Each subdirectory also has versions of the 'start', 'stop', 'test', 'test-local', and 'wait_for_mssql' scripts, but these scripts mostly delegate to their counterparts in the parent test directory (so that any changes to scripts in the parent directory will not have to be duplicated in the subdirectories). Addresses serverless-broker Issue #1017.
diverdane
pushed a commit
that referenced
this issue
Jan 2, 2020
This test extends the MSSQL integration tests by adding test for running the existing test suite against the following MSSQL server versions: - 2019-latest - 2017-CU1-ubuntu in addition to the `2017-latest` version that is used in the existing test. The integration tests for each new server version have been added in their own subdirectory in the MSSQL test directory. This will allow for different server versions to be incrementally added/removed over time without affecting the default testing that uses MSSQL server version 2017-latest. Each MSSQL server version test subdirectory has its own versions of docker-compose.yml and secretless.yml that use different values of host ports for the various services so that they can run concurrently. Each subdirectory also has versions of the 'start', 'stop', 'test', 'test-local', and 'wait_for_mssql' scripts, but these scripts mostly delegate to their counterparts in the parent test directory (so that any changes to scripts in the parent directory will not have to be duplicated in the subdirectories). Addresses serverless-broker Issue #1017.
diverdane
pushed a commit
that referenced
this issue
Jan 2, 2020
This test extends the MSSQL integration tests by adding test for running the existing test suite against the following MSSQL server versions: - 2019-latest - 2017-CU1-ubuntu in addition to the `2017-latest` version that is used in the existing test. The integration tests for each new server version have been added in their own subdirectory in the MSSQL test directory. This will allow for different server versions to be incrementally added/removed over time without affecting the default testing that uses MSSQL server version 2017-latest. Each MSSQL server version test subdirectory has its own versions of docker-compose.yml and secretless.yml that use different values of host ports for the various services so that they can run concurrently. Each subdirectory also has versions of the 'start', 'stop', 'test', 'test-local', and 'wait_for_mssql' scripts, but these scripts mostly delegate to their counterparts in the parent test directory (so that any changes to scripts in the parent directory will not have to be duplicated in the subdirectories). Addresses serverless-broker Issue #1017.
diverdane
pushed a commit
that referenced
this issue
Jan 3, 2020
This test extends the MSSQL integration tests by adding test for running the existing test suite against the following MSSQL server versions: - 2019-latest - 2017-CU1-ubuntu in addition to the `2017-latest` version that is used in the existing test. The integration tests for each new server version have been added in their own subdirectory in the MSSQL test directory. This will allow for different server versions to be incrementally added/removed over time without affecting the default testing that uses MSSQL server version 2017-latest. Each MSSQL server version test subdirectory has its own versions of docker-compose.yml and secretless.yml that use different values of host ports for the various services so that they can run concurrently. Each subdirectory also has versions of the 'start', 'stop', 'test', 'test-local', and 'wait_for_mssql' scripts, but these scripts mostly delegate to their counterparts in the parent test directory (so that any changes to scripts in the parent directory will not have to be duplicated in the subdirectories). Addresses serverless-broker Issue #1017.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Note: This User Story depends upon Issue #1016 "The MSSQL connector faithfully passes the login response"
Some Background:
The OK message is a.k.a. the TDS login response, and this response message contains a LOGINACK token stream (details in links below).
The TDS login response is documented here:
MS-TDS Login Response
with details about fields here:
LOGINACK
Here's a sample LOGINACK token stream, taken from a Wireshark capture:
Token - LoginAck
Token length: 54
Interface: 1
TDS version: 0x74000004
Server name: Microsoft SQL Server
Server Version: 14.0.3257
Here is the current published version of TDS:
current published version of TDS and the previous versions of TDS.
Versions of TDS to test:
Comparing previous versions of the Login response, the syntax has not changed since 2013 (or perhaps earlier). The TDS version that is included in the MSSQL server docker images hasn't changed since at least 2017 (all tagged images use 7.4).
Versions of MSSQL server to test:
Microsoft has published various images of the SQL server docker image. Some tags that can be used:
2017-latest2019-latest(same aslatest?)2017-CU1-ubuntu(oldest image?)AC:
The text was updated successfully, but these errors were encountered: