Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSSQL: Initial support for sslmode #1163

Closed
2 tasks done
doodlesbykumbi opened this issue Mar 24, 2020 · 0 comments
Closed
2 tasks done

MSSQL: Initial support for sslmode #1163

doodlesbykumbi opened this issue Mar 24, 2020 · 0 comments
Assignees
@BradleyBoutcher
Labels
component/secretless-broker kind/enhancement
Milestone
Secretless MSSQL ...

Comments

@doodlesbykumbi
Copy link
Contributor

doodlesbykumbi commented Mar 24, 2020 •
edited by BradleyBoutcher

For this issue sslmode need only take the value disable, in fact this is the default value at this point. sslmode=disable means no TLS and so that should be reflected in the behavior.

Acceptance Criteria

  • sslmode is an acceptable value in the credentials section of the MSSQL connector and its value dictates the configuration of encryption between Secretless and the target service
  • Unit/Integration tests exist for sslmode=disable
@BradleyBoutcher BradleyBoutcher self-assigned this Mar 30, 2020
BradleyBoutcher added a commit that referenced this issue Mar 31, 2020
@BradleyBoutcher
#1163 Initial support for sslmode
629ea68 
- Allow sslmode as a user specified connection detail

- Perform logic for the preloginResponse depending on
what the user requested and what the server actually supports
This can be expanded as we begin supporting other sslmodes

- tests for encryption logic for preloginResponse
BradleyBoutcher added a commit that referenced this issue Mar 31, 2020
@BradleyBoutcher
#1163 Initial support for sslmode
749ede6 
- Allow sslmode as a user specified connection detail

- Perform logic for the preloginResponse depending on
what the user requested and what the server actually supports
This can be expanded as we begin supporting other sslmodes

- tests for encryption logic for preloginResponse
BradleyBoutcher added a commit that referenced this issue Mar 31, 2020
@BradleyBoutcher
#1163 Initial support for sslmode
7021c4d 
- Allow sslmode as a user specified connection detail

- Perform logic for the preloginResponse depending on
what the user requested and what the server actually supports
This can be expanded as we begin supporting other sslmodes

- tests for encryption logic for preloginResponse
BradleyBoutcher added a commit that referenced this issue Apr 1, 2020
@BradleyBoutcher
#1163 Initial support for sslmode
d9dca62 
- Allow sslmode as a user specified connection detail

- Perform logic for the preloginResponse depending on
what the user requested and what the server actually supports
This can be expanded as we begin supporting other sslmodes

- tests for encryption logic for preloginResponse
BradleyBoutcher added a commit that referenced this issue Apr 1, 2020
@BradleyBoutcher
#1163 Initial support for sslmode
fdd08b3 
- Allow sslmode as a user specified connection detail

- Perform logic for the preloginResponse depending on
what the user requested and what the server actually supports
This can be expanded as we begin supporting other sslmodes

- tests for encryption logic for preloginResponse
BradleyBoutcher added a commit that referenced this issue Apr 1, 2020
@BradleyBoutcher
#1163 Initial support for sslmode
8373aa5 
- Allow sslmode as a user specified connection detail

- Perform logic for the preloginResponse depending on
what the user requested and what the server actually supports
This can be expanded as we begin supporting other sslmodes

- tests for encryption logic for preloginResponse
BradleyBoutcher added a commit that referenced this issue Apr 1, 2020
@BradleyBoutcher
#1163 Initial support for sslmode
b5c6631 
- Allow sslmode as a user specified connection detail

- Perform logic for the preloginResponse depending on
what the user requested and what the server actually supports
This can be expanded as we begin supporting other sslmodes

- tests for encryption logic for preloginResponse
BradleyBoutcher added a commit that referenced this issue Apr 1, 2020
@BradleyBoutcher
#1163 Initial support for sslmode
ece1559 
- Allow sslmode as a user specified connection detail

- Perform logic for the preloginResponse depending on
what the user requested and what the server actually supports
This can be expanded as we begin supporting other sslmodes

- tests for encryption logic for preloginResponse
BradleyBoutcher added a commit that referenced this issue Apr 1, 2020
@BradleyBoutcher
#1163 Initial support for sslmode
57b9235 
- Allow sslmode as a user specified connection detail

- Perform logic for the preloginResponse depending on
what the user requested and what the server actually supports
This can be expanded as we begin supporting other sslmodes

- tests for encryption logic for preloginResponse
BradleyBoutcher added a commit that referenced this issue Apr 1, 2020
@BradleyBoutcher
#1163 Initial support for sslmode
3bc2d90 
- Allow sslmode as a user specified connection detail

- Perform logic for the preloginResponse depending on
what the user requested and what the server actually supports
This can be expanded as we begin supporting other sslmodes

- tests for encryption logic for preloginResponse
@BradleyBoutcher BradleyBoutcher mentioned this issue Apr 1, 2020
Merged
doodlesbykumbi added a commit that referenced this issue Apr 3, 2020
@doodlesbykumbi
Merge pull request #1177 from cyberark/1163-disable-sslmode
642c39a 
(#1163) Initial support for sslmode
@izgeri izgeri mentioned this issue Apr 7, 2020
Closed
2 tasks
@izgeri izgeri closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BradleyBoutcher BradleyBoutcher

Labels
component/secretless-broker kind/enhancement
Milestone
Secretless MSSQL connector has TLS su...
Development

No branches or pull requests
3 participants
@doodlesbykumbi @BradleyBoutcher @izgeri