Update conjur-authn-k8s-client version #1060
Conversation
There was a problem hiding this comment.
This is going to require updating the acknowledgements. If you feel up to it you can take a crack at it following the instructions in CONTRIBUTING, but if not I'm happy to do this when I am back online
I'd also prefer to wait to tag a version until @sgnn7 has his bug fix in
orenbm
force-pushed
the
use-new-client
branch
from
52390f1
to
f4e1c9f
Compare
Done. I updated the |
orenbm
force-pushed
the
use-new-client
branch
from
f4e1c9f
to
2a855c5
Compare
orenbm
changed the title
orenbm
changed the title
orenbm
force-pushed
the
use-new-client
branch
from
3df4f17
to
ae1f5f7
Compare
CHANGELOG.md
Outdated
| @@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ## [1.5.0] - 2019-12-29 | |||
There was a problem hiding this comment.
Please don't update the changelog - we do that when we're ready to tag a release
pkg/secretless/version.go
Outdated
| @@ -4,7 +4,7 @@ import "fmt" | |||
|
|
|||
| // Version field is a SemVer that should indicate the baked-in version | |||
| // of the broker | |||
| var Version = "1.4.1" | |||
| var Version = "1.5.0" | |||
There was a problem hiding this comment.
I would not like to bump the version with this PR - please leave at 1.4.1 and we'll bump soon in a separate PR
There was a problem hiding this comment.
Thanks for integrating these changes, and updating the acknowledgements file @orenbm! I'd like to leave the version at 1.4.1 for now, and before we merge this PR I'd like to run through our manual tests to validate the change since they'll be impacted by it. That's going to take me a couple of days to do with the holiday, but hopefully we'll get this merged in shortly.
orenbm
force-pushed
the
use-new-client
branch
from
ae1f5f7
to
eda1d12
Compare
NOTICES.txt
Outdated
| @@ -157,7 +157,7 @@ See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
|
|
|||
|
|
|||
| >>> github.com/cyberark/conjur-authn-k8s-client-0.13.0 | |||
| >>> github.com/cyberark/conjur-authn-k8s-client-0.15.0 | |||
|
|
|||
| Copyright [yyyy] [name of copyright owner] | |||
There was a problem hiding this comment.
the copyright actually changed in this version, can you please copy/paste the updated one here?
orenbm
changed the title
orenbm
force-pushed
the
use-new-client
branch
from
eda1d12
to
10dac3d
Compare
The method signature for NewFromEnv has changed that it takes no arguments and has default parameters instead.
Blocked by #1057
What does this PR do (include background context, if relevant)?
We released a new authn-client that adds the ability to authenticate hosts from anywhere in the policy branch. This PR updates the version of the conjur-authn-k8s-client that is used in this project
Tests for this feature are already implemented in
kubernetes-conjur-demo.What ticket does this PR close?
Connected to cyberark/conjur#1239