Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate secrets base path into secret group filepath #381

Merged
merged 5 commits into from
Nov 4, 2021

Conversation

doodlesbykumbi
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi commented Oct 29, 2021

Implemented Changes

Carried out in collaboration with @john-odonnell.

These changes were initially meant to land with the PR for Onyx-11974. They incorporate the secrets base path /conjur/secret onto the relative file paths for each secret group defined by annotations, and handle validations.

Connected Issue/Story

CyberArk internal issue link: Onyx-11974

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@doodlesbykumbi doodlesbykumbi requested review from a team as code owners October 29, 2021 17:04
@doodlesbykumbi doodlesbykumbi changed the base branch from ONYX-12559 to main October 29, 2021 18:36
@doodlesbykumbi doodlesbykumbi force-pushed the secret-file-path-fix-review branch 2 times, most recently from 79151b0 to 425e96a Compare October 29, 2021 20:22
@doodlesbykumbi doodlesbykumbi force-pushed the secret-file-path-fix-review branch 3 times, most recently from c6071f4 to 9dbacd5 Compare October 29, 2021 21:17
john-odonnell and others added 5 commits November 3, 2021 18:48
Adds more unit tests for the secret group filepath behavior, adds edge case and refactors some interaction with paths
This change applies this default both at annotation parsing time and at secret fetching time.
@codeclimate
Copy link

codeclimate bot commented Nov 3, 2021

Code Climate has analyzed commit 49a5d0d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 86.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.1% (1.0% change).

View more on Code Climate.

@szh szh mentioned this pull request Nov 3, 2021
13 tasks
Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants