Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendored dependencies, upgrade to aws-sdk-go-v2 #23

Merged
merged 2 commits into from Mar 14, 2023

Conversation

gl-johnson
Copy link
Contributor

@gl-johnson gl-johnson commented Mar 6, 2023

Desired Outcome

Resolve CVE-2022-0778 and CVE-2022-1292 which are stemming from the vendored version of aws-sdk-go.

Implemented Changes

  • Switch repo to go modules
  • Migrate from aws-sdk-go (v1.12.14) to aws-sdk-go-v2 (v1.17.5)
  • Upgrade Go builder images to 1.19
  • Add e2e test

Smoke-tested on MacOS with env variable configuration:

export AWS_REGION=us-east-1
export AWS_ACCESS_KEY_ID=<redacted>
export AWS_SECRET_ACCESS_KEY=<redacted>

summon --provider ./pkg/darwin/summon-s3 \
--yaml 'TEST_CRED: !var glen-johnson.bucket/cred.txt' \
printenv TEST_CRED
hello world!!!!!

Also added an e2e test in CI which does the same as above, but using creds for Cyberark's AWS and a sample s3 secret.
Jenkins: https://jenkins.conjur.net/blue/organizations/jenkins/cyberark--summon-s3/detail/aws-sdk-go-v2/26

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@gl-johnson gl-johnson marked this pull request as ready for review March 7, 2023 14:44
@gl-johnson gl-johnson requested a review from a team as a code owner March 7, 2023 14:44
@gl-johnson gl-johnson force-pushed the aws-sdk-go-v2 branch 3 times, most recently from 97abc7a to 0fc5276 Compare March 8, 2023 16:14
@gl-johnson gl-johnson marked this pull request as draft March 8, 2023 16:16
@gl-johnson gl-johnson force-pushed the aws-sdk-go-v2 branch 11 times, most recently from d905657 to 5b909ce Compare March 8, 2023 19:50
@gl-johnson gl-johnson marked this pull request as ready for review March 8, 2023 19:53
Copy link

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gl-johnson gl-johnson merged commit 4f6b7ad into main Mar 14, 2023
@gl-johnson gl-johnson deleted the aws-sdk-go-v2 branch March 14, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants