Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go modules in go.mod #123

Merged
merged 1 commit into from May 23, 2023
Merged

Upgrade go modules in go.mod #123

merged 1 commit into from May 23, 2023

Conversation

juniortaeza
Copy link
Contributor

@juniortaeza juniortaeza commented May 22, 2023

Desired Outcome

This pull request upgrades go.mod and go.sum

Implemented Changes

  • upgrades golang.org/x/text to v0.3.8
  • upgrades golang.org/x/sys to v0.8.0
  • golang.org/x/crypto is already at proper version

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@juniortaeza juniortaeza requested a review from a team as a code owner May 22, 2023 17:39
Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go.sum is showing this version for golang.org/x/crypto: v0.0.0-20210921155107-089bfa567519 which seems to be a lower version than we want. You may need to add an additional replace statement and go mod tidy to fix it

Additionally - any lower versions of golang.org/x/text and golang.org/x/sys that are still showing up in go.sum after the changes you've made may also require explicit replaces to the new version

@juniortaeza
Copy link
Contributor Author

Updated! Thanks @gl-johnson

go.mod Outdated Show resolved Hide resolved
@juniortaeza juniortaeza merged commit 0c9fe2c into main May 23, 2023
1 check passed
@john-odonnell john-odonnell deleted the upgrade-modules-branch branch May 30, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants