Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply fixes from StyleCI #1

Merged
merged 1 commit into from Jan 8, 2017
Merged

Apply fixes from StyleCI #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Module/Config/Step/OverrideConfigFromCLI.php
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ public function __invoke(Project $project)
if (!$project->metadata['cliConfig']) {
return;
}

$cliConfig = [];
foreach ($project->metadata['cliConfig'] as $item) {
$explosion = explode('=', $item, 2);
Expand Down
7 changes: 3 additions & 4 deletions tests/UnitTest/Module/Config/Step/OverrideConfigFromCLITest.php
View file
Open in desktop
Expand Up @@ -4,7 +4,6 @@

use Couscous\Module\Config\Step\OverrideConfigFromCLI;
use Couscous\Tests\UnitTest\Mock\MockProject;
use Psr\Log\LoggerInterface;

/**
* @covers \Couscous\Module\Config\Step\OverrideConfigFromCLI
Expand All @@ -19,7 +18,7 @@ public function should_override_title_if_specified()
$project = new MockProject();
$project->metadata['title'] = 'foo';
$project->metadata['cliConfig'] = ['title=bar'];

$logger = $this->getMock("Psr\Log\LoggerInterface");

$step = new OverrideConfigFromCLI($logger);
Expand All @@ -36,7 +35,7 @@ public function should_not_override_title_if_not_specified()
$project = new MockProject();
$project->metadata['title'] = 'foo';
$project->metadata['cliConfig'] = [];

$logger = $this->getMock("Psr\Log\LoggerInterface");

$step = new OverrideConfigFromCLI($logger);
Expand All @@ -52,7 +51,7 @@ public function should_not_override_title_if_no_cliConfig()
{
$project = new MockProject();
$project->metadata['title'] = 'foo';

$logger = $this->getMock("Psr\Log\LoggerInterface");

$step = new OverrideConfigFromCLI($logger);
Expand Down