Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Asset.parameters #11

Open
fabienrohrer opened this issue Feb 5, 2019 · 1 comment
Open

Improve Asset.parameters #11

fabienrohrer opened this issue Feb 5, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@fabienrohrer
Copy link
Member

For now, the customizable parameters are TinkerbotsAxle.length (actually not implemented), TinkerbotsCubiePyramid.color and TinkerbotsCubieTriangle.color. In Webots, they are all string enumerations, and affects the Shape (color or shape).

In the contrary of translation or rotation where the THREEjs <-> Webots link is direct, this kind of links should be coded somewhere. For now it's hard-coded here: https://github.com/omichel/robot-designer/blob/master/app/view/mediator/part_mediator.js#L78

To solve this, we should either provide a generic way to write these links, or to have several x3d files (e.g. one x3d file per parameter set).

@fabienrohrer fabienrohrer added the enhancement New feature or request label Feb 5, 2019
@fabienrohrer
Copy link
Member Author

Moreover, initializing a parameter affecting a mesh in the part constructor is not straightforward, because the representation may be not loaded (x3d files are loaded asynchronously). This is currently the case when undo/redo the deletion of a colored mesh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants