Fix assets.json

[stefaniapedrazzi]

Fix incorrect slots definitions in assets.json.

[fabienrohrer]

TinkerbotsCubieBoxWithRoundSlots are badly designed in Webots. left/right slots should be replaced by front/back slots otherwise there is an overlap.
For its axis slot, a rotation (currently disabled) would be required to put it at the right place.

I recommend to accept this PR as-is and to fix these issues later, as it is already a good improvement. The biggest issue is the motor slot swap.

[fabienrohrer]

👍

[fabienrohrer]

👎 Just found other bugs (cube front/back tinkerbots slots are inverted). Webots fixes are required.

[stefaniapedrazzi]

I checked in Webots as well and the TinkerbotsCubieBoxWithRoundSlots model has an up, left and right slots that matches the ones in the TinkerbotsCubieBoxWithCrossSlots.
So I understand that you removed the front and back slots and replaced them by the axis slot, but I understand why you also removed the up, left and right slots.
With this status, it is not possible to build the racer and roadster models.

[fabienrohrer]

You're right (except I didn't remove the up slot). The axisSlot and upSlot should be sufficient to create racer and roadster (except it's not possible to rotate the axis slot due to #7 so the wheels and axis will be badly oriented).

About the left and right removal, my concern is that there is an issue in Webots: TinkerbotsCubieBoxWithRoundSlots.leftSlot and TinkerbotsCubieBoxWithRoundSlots.axisSlot are wrongly defined at the same position. We should probably add front and back slots instead of left and right slots in Webots (I have to log this somewhere).

So I decided to remove them until we fix the Webots model.

[fabienrohrer]

I just added an issue here: https://github.com/omichel/webots/issues/215

[stefaniapedrazzi]

Why you didn't use the Webots mechanism to specify the gender for the Tinkerbots slots?
https://www.cyberbotics.com/doc/reference/slot#field-summary

[fabienrohrer]

To be honest, I was not aware of the gender mechanism, sorry for this. We could improve the models this way.

[stefaniapedrazzi]

Ok thank you for the explanation.
I think it would be better to fix all the robot designer and Webots slots issues now (in develop branch if needed) instead of having to do it again later.

[fabienrohrer]

Yes it would be good to fix this soon, but I would recommend to accept this PR because it fixes also lot of other small obvious issues not related with Webots.

[fabienrohrer]

👍

[stefaniapedrazzi]

👀

[stefaniapedrazzi]

My fix for the male cube was wrong: left and right where simply inverted.
Not it matches the status in Webots.
But there are inconsistencies between slot position in male and female cube to solve (Webots as well).

👍

[stefaniapedrazzi]

Oops it is still wrong, I'm fixing it.

[stefaniapedrazzi]

👍

[fabienrohrer]

Well spotted, thank you