Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the scale field to Mesh and Collada nodes #157

Merged
merged 5 commits into from
Feb 25, 2022
Merged

Add the scale field to Mesh and Collada nodes #157

merged 5 commits into from
Feb 25, 2022

Conversation

BenjaminHug8
Copy link
Contributor

@BenjaminHug8 BenjaminHug8 commented Feb 8, 2022 •
edited

This PR solves #152 and #153.

Linked to cyberbotics/webots#4243.

@BenjaminHug8 BenjaminHug8 added the enhancement New feature or request label Feb 8, 2022
@BenjaminHug8 BenjaminHug8 self-assigned this Feb 8, 2022
@BenjaminHug8 BenjaminHug8 marked this pull request as ready for review February 25, 2022 10:00
omichel
omichel previously approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems good to me.
I know my suggestion is not the purpose of this PR, but we could make it here if easy to do or in a separate PR.

urdf2webots/writeRobot.py Outdated Show resolved Hide resolved
omichel
omichel requested changes Feb 25, 2022
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments may also apply to other default values, like Sphere.radius, Box.size, etc.

urdf2webots/writeRobot.py Outdated Show resolved Hide resolved
urdf2webots/writeRobot.py Outdated Show resolved Hide resolved
omichel
omichel approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you.

@BenjaminHug8 BenjaminHug8 merged commit 95760da into develop Feb 25, 2022
@BenjaminHug8 BenjaminHug8 deleted the feature-size-mesh branch February 25, 2022 13:55
This was referenced Feb 25, 2022
Closed
Closed
@rokusottervanger rokusottervanger mentioned this pull request May 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omichel omichel omichel approved these changes

Assignees

@BenjaminHug8 BenjaminHug8

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BenjaminHug8 @omichel